xds: emit a labeled gauge of connected xDS streams by version #10243
Conversation
| @@ -647,3 +660,23 @@ func runStep(t *testing.T, name string, fn func(t *testing.T)) { | |||
| t.FailNow() | |||
| } | |||
| } | |||
|
|
|||
| func requireProtocolVersionGauge( | |||
There was a problem hiding this comment.
Do you expect that we will call this from other places? Right now it's only called from one place so it might be good to keep it next to the one call site.
There was a problem hiding this comment.
It's called in two places: server_test.go and delta_test.go for v2 and v3 respectively.
|
🤔 This PR has changes in the |
|
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/369442. |
|
🍒✅ Cherry pick of commit ede14b7 onto |
| @@ -141,6 +150,36 @@ type Server struct { | |||
| AuthCheckFrequency time.Duration | |||
|
|
|||
| DisableV2Protocol bool | |||
|
|
|||
There was a problem hiding this comment.
Am I correct in assuming that there can only be one Server instance per host? Do we run multiple servers on different ports or anything like that?
There was a problem hiding this comment.
There is exactly one xDS server per consul agent.
Fixes #10099