Deprecate API driven licensing #10211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkeeler
force-pushed
the
hcs-1925-license-autoloading
branch
from
cdb8b17 to
984080e
Compare
mkeeler
force-pushed
the
hcs-1926-deprecate-api-licensing
branch
from
c13495f to
3b55a54
Compare
mkeeler
force-pushed
the
hcs-1926-deprecate-api-licensing
branch
from
3b55a54 to
c447818
Compare
dnephin
approved these changes
May 10, 2021
mkeeler
force-pushed
the
hcs-1925-license-autoloading
branch
from
984080e to
0e98259
Compare
mkeeler
force-pushed
the
hcs-1926-deprecate-api-licensing
branch
from
c447818 to
f5b2379
Compare
The two methods in the API client to Put or Reset a license will now always return an error.
mkeeler
force-pushed
the
hcs-1926-deprecate-api-licensing
branch
from
f5b2379 to
ca4da22
Compare
|
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/372090. |
|
🍒✅ Cherry pick of commit 08eb600 onto |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two methods in the API client to Put or Reset a license will now always return an error. These APIs will no longer exist in Consul Enterprise so instead of just getting 405s or removing the methods which would require a v2 of the API for Go module semantic version compatibility, I have chosen to have these return a predefined error noting that the functionality was removed in v1.10.0