-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: Fix empty SVG height #10122
ui: Fix empty SVG height #10122
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey 👋!
I'm not 100% sure what this fixes, could you add something to the description for me?
Apart from that I left a little inline comment suggestion.
@johncowen I've added a description. |
Hey thanks for fixing this up. I was wondering if this is a good opportunity to add some additional testing around this somewhere. What do you think? We could test for 0 'streams in each column and make sure no errors are thrown? |
@johncowen I'll have to leave this for GA. I'm going to be changing some things for that *(All Services) card. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! One little thing, I think when we spoke you mentioned changing the changelog a little, not sure if you are going to do that or not.
…here are no upstreams (#10122)
…here are no upstreams (#10122)
Adding a conditional that prevents the Topology view from breaking when there are no upstreams in the upstream column.
Before
After