connect: update supported envoy versions to 1.18.2, 1.17.2, 1.16.3, and 1.15.4 #10101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
theme/cli
rboyer
commented
Apr 23, 2021
| @@ -642,6 +643,7 @@ func TestClustersFromSnapshot(t *testing.T) { | |||
| } | |||
|
|
|||
| latestEnvoyVersion := proxysupport.EnvoyVersions[0] | |||
| latestEnvoyVersion_v2 := proxysupport.EnvoyVersionsV2[0] | |||
There was a problem hiding this comment.
I realized when I went to update these golden tests that my last refactor hadn't accounted for skipping v2-compat tests for >= 1.17.x. All of the golden tests got similar adjustments.
rboyer
commented
Apr 23, 2021
| @@ -28,6 +28,13 @@ | |||
| "routeConfigName": "db" | |||
| }, | |||
| "httpFilters": [ | |||
| { | |||
rboyer
commented
Apr 23, 2021
| @@ -28,6 +28,13 @@ | |||
| "routeConfigName": "db" | |||
| }, | |||
| "httpFilters": [ | |||
| { | |||
rboyer
commented
Apr 23, 2021
Comment on lines
38
to
40
| | 1.9.x | 1.16.3, 1.15.4, 1.14.7‡, 1.13.8‡ | | ||
| | 1.8.x | 1.14.7, 1.13.8, 1.12.7, 1.11.2 | | ||
| | 1.7.x | 1.13.8, 1.12.7, 1.11.2, 1.10.0\* | |
There was a problem hiding this comment.
The manual backports of this pr to the older series will finish making these 3 lines true.
rboyer
force-pushed
the
envoy-integ-pgrep
branch
from
ce361b6 to
2d6c051
Compare
This was referenced Apr 23, 2021
freddygv
reviewed
Apr 26, 2021
|
@freddygv deleting the debugging file |
Co-authored-by: Freddy <[email protected]>
freddygv
approved these changes
Apr 29, 2021
|
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/360035. |
|
🍒✅ Cherry pick of commit abc1dc0 onto |
hc-github-team-consul-core
pushed a commit
that referenced
this pull request
Apr 29, 2021
…nd 1.15.4 (#10101) The only thing that needed fixing up pertained to this section of the 1.18.x release notes: > grpc_stats: the default value for stats_for_all_methods is switched from true to false, in order to avoid possible memory exhaustion due to an untrusted downstream sending a large number of unique method names. The previous default value was deprecated in version 1.14.0. This only changes the behavior when the value is not set. The previous behavior can be used by setting the value to true. This behavior change by be overridden by setting runtime feature envoy.deprecated_features.grpc_stats_filter_enable_stats_for_all_methods_by_default. For now to maintain status-quo I'm explicitly setting `stats_for_all_methods=true` in all versions to avoid relying upon the default. Additionally the naming of the emitted metrics for these gRPC requests changed slightly so the integration test assertions for `case-grpc` needed adjusting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only thing that needed fixing up pertained to this section of the 1.18.x release notes:
For now to maintain status-quo I'm explicitly setting
stats_for_all_methods=truein all versions to avoid relying upon the default.Additionally the naming of the emitted metrics for these gRPC requests changed slightly so the integration test assertions for
case-grpcneeded adjusting.