-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update brand assets #10081
Update brand assets #10081
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @dizzyup
I know you are still working on this, but I noticed a couple of things I thought I'd mention.
Firstly, oh my wordy 😍 !
Also, thanks for cleaning up all those extraneous files!
Couple of things I wanted to ask were:
- Is the SVG you are using 'minizable' at all, can we use
svgo
on it? - I noticed the logo uses the newer color scheme also, I can think of one place off the top of my head where we use a shade of the older
magenta
scheme, is it worthwhile tweaking that in this PR also? (I just merged a PR that would affect where that would be done, I'm just gonna look now so I can point you to it if you wanted to do that here - gah I just thought, it would be slightly different for the 2 branches also) Anyway let me know if you want to do that here at all, or me or you do it separately.
@johncowen No problem!
So the asset has actually already gone through SVGO before I embed the markup - the larger size is because the new SVG has more points along the paths. I'm not sure there's any further optimisation that can happen there.
It might be, though I was steering clear of wider design changes to make sure just the brandmark was the thing being landed. What would the change affect specifically? The marketing guidelines for the brand give us |
Oh cool, would it be ok to make a
We use it for the underline highlights for our tabs, and then a tiny detail of code syntax highlighting for our inline code style. We can change that up at a later date tho if thats better. |
Great idea, will do that now!
I'm not against that at all! Do you want to try applying |
Yeah sure, could you rebase this one for me and I'll make a little branch off here |
60acb83
to
916f1d5
Compare
.is-debug .brand-loader { | ||
display: none !important; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@johncowen Given that the eng docs only show locally, I think this solution is ok because this style is only loaded when we're a) local, b) looking at the docs and c) the docs css has been loaded (so we can hide the loading state).
Have I missed anything with this approach?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't think so, thanks for extra explanation!
Ping me when this is out of draft and I can give it a 👍
[role='banner'] nav:first-of-type { | ||
height: calc(100vh - var(--chrome-height, 47px)); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@johncowen Noticed in the eng docs that the left-hand navigation had a gap at the bottom. This rule is a version of the standard one but removes the - 35px
portion of that calc.
- Switches to serve an ico file alongside an SVG file - Introduces an apple-touch-icon
78fd690
to
3f22f8e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super good! Thanks for the tweaks there too!
👍
* Update header logo and inline icon * Update full logos + layout on loading screen * Update favicon assets and strategy - Switches to serve an ico file alongside an SVG file - Introduces an apple-touch-icon * Removes unused favicon/meta assets * Changelog item for ui * Create component for logo * Simplify logo component, set brand color * Fix docs loading state CSS issue
* Update header logo and inline icon * Update full logos + layout on loading screen * Update favicon assets and strategy - Switches to serve an ico file alongside an SVG file - Introduces an apple-touch-icon * Removes unused favicon/meta assets * Changelog item for ui * Create component for logo * Simplify logo component, set brand color * Fix docs loading state CSS issue
* Update header logo and inline icon * Update full logos + layout on loading screen * Update favicon assets and strategy - Switches to serve an ico file alongside an SVG file - Introduces an apple-touch-icon * Removes unused favicon/meta assets * Changelog item for ui * Create component for logo * Simplify logo component, set brand color * Fix docs loading state CSS issue
This PR introduces updated brand assets for Consul (against v1.10).
There's also a version of this same PR against v1.9.3 - #10090
Note
This isn't intended to go live until the wider rollout happens which is being handled by marketing - I'd like to get this work reviewed though so we can merge once marketing ship the other Consul properties.
Changelog
As part of the favicon/meta work I took the opportunity to update the strategy there so we serve a
favicon.svg
alongside afavicon.ico
file, together with an Apple Touch Icon asset.