snapshot: fix saving of auth methods #10025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously only a single auth method would be saved to the snapshot. This commit fixes the typo and adds to the test, to show that all auth methods are now saved.
dnephin
force-pushed
the
dnephin/fix-snapshot-auth-methods
branch
from
5a38a68 to
88f83b4
Compare
mkeeler
approved these changes
Apr 14, 2021
|
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/350232. |
|
🍒✅ Cherry pick of commit a2726e8 onto |
hashicorp-ci
pushed a commit
that referenced
this pull request
Apr 14, 2021
…thods snapshot: fix saving of auth methods
dnephin
added a commit
that referenced
this pull request
Apr 14, 2021
…thods snapshot: fix saving of auth methods
dnephin
added a commit
that referenced
this pull request
Apr 14, 2021
…thods snapshot: fix saving of auth methods
This was referenced Apr 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9784
Previously only a single auth method would be saved to the snapshot. This commit fixes the typo and adds to the test, to show that all auth methods are now saved.