Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Structured logging support #82

Closed
edevil opened this issue Aug 28, 2020 · 2 comments · Fixed by #97 or #105
Closed

Structured logging support #82

edevil opened this issue Aug 28, 2020 · 2 comments · Fixed by #97 or #105
Labels
enhancement
Milestone
0.6.0

Comments

@edevil
Copy link
Contributor

edevil commented Aug 28, 2020

In the spirit of hashicorp/consul#7130, I think it would be great if ESM also supported structured logging.

What do you think of doing the same thing here?
@lornasong lornasong mentioned this issue Sep 10, 2020
Closed
@lornasong lornasong linked a pull request Jan 6, 2021 that will close this issue
Use hclog #97
Merged
@lornasong lornasong added this to the 0.6.0 milestone Jan 15, 2021
@edevil
Copy link
Contributor Author

edevil commented Feb 1, 2021

Could you tell me how to enable this currently @lornasong ? I see no flag for it... /cc @varnson

@lornasong
Copy link
Member

@edevil thanks for the question! This is my fault! @ varnson's PR is for converting the logging to hclog only and does not include the structured logs option. I will reopen this issue. Apologies for the confusion and thanks for raising this!

@lornasong lornasong reopened this Feb 3, 2021
@edevil edevil mentioned this issue Feb 11, 2021
Merged
@lornasong lornasong linked a pull request Feb 11, 2021 that will close this issue
Add configuration flag to enable JSON logging #105
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
0.6.0
Development

Successfully merging a pull request may close this issue.

Use hclog varnson/consul-esm
Add configuration flag to enable JSON logging edevil/consul-esm
2 participants
@edevil @lornasong