Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Printing to stdout messes up JSON logging #161

Closed
ilinas opened this issue Sep 14, 2022 · 0 comments · Fixed by #169
Closed

Printing to stdout messes up JSON logging #161

ilinas opened this issue Sep 14, 2022 · 0 comments · Fixed by #169
Labels
Milestone

Comments

@ilinas
Copy link

ilinas commented Sep 14, 2022

Before logging is initialized, consul-esm outputs several messages such as "Consul ESM running!" and some info about the config.

ui.Output("Consul ESM running!")

When running in Docker, these messages are being picked up by the logging driver (journald in our case), and included in the logs. We, however, are expecting JSON log by setting log_json = true in the config file, and that causes the log parser to fail.

It would be nice if there was a parameter to disable those messages, or that they would output through the configured logger in the configured format.

@eikenb eikenb added the bug label Sep 14, 2022
@eikenb eikenb added this to the v0.7.0 milestone Sep 14, 2022
@eikenb eikenb modified the milestones: v0.7.0, v0.6.2 Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants