Skip to content
This repository has been archived by the owner on Mar 19, 2024. It is now read-only.

Gateway pods fail to start when namespace doesn't exist #397

Merged
merged 37 commits into from
Oct 27, 2022
Merged

Gateway pods fail to start when namespace doesn't exist #397

merged 37 commits into from
Oct 27, 2022

Conversation

sarahalsmiller
Copy link
Member

@sarahalsmiller sarahalsmiller commented Sep 28, 2022 •
edited
Loading

Changes proposed in this PR:

  • Duplicated exists functionality from consul-k8s
  • Added EnsureNamespace logic to the deployer
  • Made minor updates to e2e test to make sure consul enterprise tests are functional with namespace mirroring turned on.

How I've tested this PR:

  • Spun up a local kind cluster
  • Wrote a local e2e test, but that test was failing even when it wasn't hitting the code path, investigating separately

How I expect reviewers to test this PR:

-Tests pass

Checklist:

  • [ X ] Tests added
  • [ X ] CHANGELOG entry added

    Run make changelog-entry for guidance in authoring a changelog entry, and
    commit the resulting file, which should have a name matching your PR number.
    Entries should use imperative present tense (e.g. Add support for...)

@sarahalsmiller sarahalsmiller linked an issue Sep 28, 2022 that may be closed by this pull request
API Gateway pods fail to start if namespace mirroring enabled and destination namespace doesn't exist #248
Closed
sarahalsmiller and others added 12 commits September 28, 2022 15:43
@sarahalsmiller
add create/delete namespace to test
dbd5eeb
@sarahalsmiller
clean up duplicated imports
6890090
@sarahalsmiller
checkout consul k8s branch
2d441b4
@sarahalsmiller
updated reployer to ensure namespace exists
d2d9adc
@sarahalsmiller
nil pointer exception
e1d6fbb
@sarahalsmiller
Merge branch 'main' into 248-api-gateway-pods-fail-to-start-if-namesp…
f58cf4b 
…ace-mirroring-enabled-and-destination-namespace-doesnt-exist
@sarahalsmiller
lint
4485c0c
@sarahalsmiller
Merge branch '248-api-gateway-pods-fail-to-start-if-namespace-mirrori…
30c552e 
…ng-enabled-and-destination-namespace-doesnt-exist' of github.com:hashicorp/consul-api-gateway into 248-api-gateway-pods-fail-to-start-if-namespace-mirroring-enabled-and-destination-namespace-doesnt-exist
@sarahalsmiller
add namespace mirrioring check
27e6f4e
@sarahalsmiller
revert extra change
5d2ceba
@sarahalsmiller
fix http listner
c93cfb0
@sarahalsmiller
removed nonfunctional test, will return to it
8f832f7
@sarahalsmiller sarahalsmiller changed the title WIP - Gateway pods fail to start when namespace doesn't exist Gateway pods fail to start when namespace doesn't exist Oct 6, 2022
@sarahalsmiller sarahalsmiller marked this pull request as ready for review October 11, 2022 17:34
nathancoleman
nathancoleman reviewed Oct 17, 2022
View reviewed changes
sarahalsmiller and others added 2 commits October 17, 2022 17:37
@sarahalsmiller @nathancoleman
Update .changelog/397.txt
e4242ab 
Co-authored-by: Nathan Coleman <[email protected]>
@sarahalsmiller
Merge branch 'main' into 248-api-gateway-pods-fail-to-start-if-namesp…
08e06e0 
…ace-mirroring-enabled-and-destination-namespace-doesnt-exist
nathancoleman
nathancoleman suggested changes Oct 25, 2022
View reviewed changes
Copy link
Member

@nathancoleman nathancoleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So excited to see this bug patched! Nice work 🎉

nathancoleman
nathancoleman approved these changes Oct 27, 2022
View reviewed changes
@nathancoleman nathancoleman self-requested a review October 27, 2022 18:21
@nathancoleman
Copy link
Member

@sarahalsmiller looks like there was a small merge conflict with #405 which just merged

@sarahalsmiller
Merge branch 'main' into 248-api-gateway-pods-fail-to-start-if-namesp…
06c5c6a 
…ace-mirroring-enabled-and-destination-namespace-doesnt-exist
@sarahalsmiller sarahalsmiller merged commit a850294 into main Oct 27, 2022
@sarahalsmiller sarahalsmiller deleted the 248-api-gateway-pods-fail-to-start-if-namespace-mirroring-enabled-and-destination-namespace-doesnt-exist branch October 27, 2022 18:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nathancoleman nathancoleman nathancoleman approved these changes

@andrewstucki andrewstucki Awaiting requested review from andrewstucki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API Gateway pods fail to start if namespace mirroring enabled and destination namespace doesn't exist
2 participants
@sarahalsmiller @nathancoleman