This repository has been archived by the owner on Mar 19, 2024. It is now read-only.
fix listener and route behavior when changing ParentRef #200
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
Fixes the following issue:
attachedRoutes
back to zero when last route removes a ParentRef for that gatewayUpdates test to document currently-expected behavior but not fixed yet - after discussing with @nathancoleman we believe support for multiple gateways is not yet implemented rather than a "bug":
no healthy upstream
) until the first ParentRef is removedHow I've tested this PR:
Written e2e test assertions that demonstrate broken behavior when changing the ParentRef of a route.
How I expect reviewers to test this PR:
Confirm that new test assertions demonstrate intended functionality, review fixes.
Checklist: