Skip to content
This repository has been archived by the owner on Mar 19, 2024. It is now read-only.

fix listener and route behavior when changing ParentRef #200

Merged
merged 6 commits into from
Jun 3, 2022

Conversation

mikemorris
Copy link
Contributor

@mikemorris mikemorris commented May 26, 2022

Changes proposed in this PR:

Fixes the following issue:

  • Prior gateway listener doesn't update attachedRoutes back to zero when last route removes a ParentRef for that gateway

Updates test to document currently-expected behavior but not fixed yet - after discussing with @nathancoleman we believe support for multiple gateways is not yet implemented rather than a "bug":

  • An HTTPRoute fails to route traffic from a second ParentRef gateway to a backend service (503 reponses with no healthy upstream) until the first ParentRef is removed
    • Traffic does still route successfully through the first gateway after adding the second gateway ParentRef

How I've tested this PR:

Written e2e test assertions that demonstrate broken behavior when changing the ParentRef of a route.

How I expect reviewers to test this PR:

Confirm that new test assertions demonstrate intended functionality, review fixes.

Checklist:

  • Tests added
  • CHANGELOG entry added

    Run make changelog-entry for guidance in authoring a changelog entry, and
    commit the resulting file, which should have a name matching your PR number.
    Entries should use imperative present tense (e.g. Add support for...)

@mikemorris mikemorris force-pushed the bugfix/attachedroutes-retarget-parentref branch from e366f11 to 0ab29f4 Compare May 31, 2022 20:08
@mikemorris mikemorris force-pushed the bugfix/attachedroutes-retarget-parentref branch from 1835263 to c96dd28 Compare May 31, 2022 20:22
@mikemorris mikemorris marked this pull request as ready for review May 31, 2022 20:46
@mikemorris mikemorris requested a review from a team May 31, 2022 20:47
@mikemorris mikemorris merged commit 1263e71 into main Jun 3, 2022
@mikemorris mikemorris deleted the bugfix/attachedroutes-retarget-parentref branch June 3, 2022 17:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants