Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix remote config validation not working #947

Closed
instamenta opened this issue Dec 9, 2024 · 0 comments · Fixed by #967
Closed

Fix remote config validation not working #947

instamenta opened this issue Dec 9, 2024 · 0 comments · Fixed by #967
Assignees
@instamenta
Labels
Blocker Further development work cannot be done Bug A error that causes the feature to behave differently than what was expected based on design docs

Comments

@instamenta
Copy link
Contributor

instamenta commented Dec 9, 2024 •
edited
Loading

Describe the bug

Currently the attempts to find the pods for node, envoy and haproxy by their name, finding them by the labels should fix that.

Describe the expected behavior

Should not fail if the pods are present and match the remote config state

To Reproduce

add a deployment and run any command after network deploy
@instamenta instamenta added Bug A error that causes the feature to behave differently than what was expected based on design docs Pending Triage New issue that needs to be triaged by the team labels Dec 9, 2024
@instamenta instamenta self-assigned this Dec 9, 2024
@instamenta instamenta added Blocker Further development work cannot be done and removed Pending Triage New issue that needs to be triaged by the team labels Dec 9, 2024
@instamenta instamenta added this to Solo Dec 9, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in Solo Dec 9, 2024
@instamenta instamenta linked a pull request Dec 9, 2024 that will close this issue
fix: remote config validation not working #948
Closed
This was referenced Dec 9, 2024
Closed
Merged
@instamenta instamenta linked a pull request Dec 10, 2024 that will close this issue
fix: remote config validation not working #967
Merged
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Solo Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@instamenta instamenta

Labels
Blocker Further development work cannot be done Bug A error that causes the feature to behave differently than what was expected based on design docs
Projects
Solo
Status: ✅ Done
Milestone
No milestone
1 participant
@instamenta