feat: separate commands for solo node delete #597

Ivo-Yankov · 2024-09-18T11:18:07Z

Description

Separates the flow of solo node delete into 3 new commands that can be executed separately and one after the other: solo node delete-prepare, solo node delete-submit-transactions, solo node delete-execute.

The behaviour of the new commands is as follows:

solo node delete-prepare  --node-id node2 --release-tag v0.54.0-alpha.4 --namespace solo-e2e --output-dir context
---------
Initialize
Identify existing network nodes
Load node admin key
Prepare upgrade zip file for node upgrade process
Check existing nodes staked amount
Save context data

Saves data from the ctx object to the specified directory by --output-dir

solo node delete-submit-transactions --namespace solo-e2e --input-dir context
---------
Initialize
Load context data
Send node delete transaction
Send prepare upgrade transaction
Send freeze upgrade transaction

Loads data into the ctx object from the specified directory by --input-dir

solo node delete-execute --namespace solo-e2e --input-dir context [--local-build-path xxxxxxx]
---------


Initialize 
Load context data
Download generated files from an existing node 
Prepare staging directory 
  Copy Gossip keys to staging
  Copy gRPC TLS keys to staging
Copy node keys to secrets 
  Copy TLS keys 
  Node: node1 
    Copy Gossip keys 
  Node: node3 
    Copy Gossip keys 
Check network nodes are frozen 
  Check network pod: node1  
  Check network pod: node2  
  Check network pod: node3  
Get node logs and configs 
Update chart to use new configMap 
Kill nodes to pick up updated configMaps 
Check node pods are running 
  Check Node: node1 
  Check Node: node3
Fetch platform software into all network nodes 
  Update node: node1 
  Update node: node3 
Setup network nodes 
  Node: node1 
    Set file permissions 
  Node: node3 
    Set file permissions 
Start network nodes 
  Start node: node1 
  Start node: node3 
Enable port forwarding for JVM debugger
Check all nodes are ACTIVE 
  Check network pod: node1  
  Check network pod: node3  
Check all node proxies are ACTIVE 
  Check proxy for node: node1 
  Check proxy for node: node3 
Trigger stake weight calculate 
Finalize

Loads data into the ctx object from the specified directory by --input-dir

Related Issues

Closes Reusable components of solo node delete to be leveraged for SDK testing #529

Signed-off-by: Ivo Yankov <[email protected]>

…e-to-be-leveraged-for-sdk-testing

Signed-off-by: Ivo Yankov <[email protected]>

github-actions · 2024-09-18T11:20:19Z

Unit Test Results - Linux

1 files ± 0 19 suites +8 33s ⏱️ +21s
119 tests +55 119 ✅ +55 0 💤 ±0 0 ❌ ±0
145 runs +60 145 ✅ +60 0 💤 ±0 0 ❌ ±0

Results for commit c6e48eb. ± Comparison against base commit 538e40d.

♻️ This comment has been updated with latest results.

github-actions · 2024-09-18T11:21:49Z

Unit Test Results - Windows

1 files 19 suites 55s ⏱️
119 tests 119 ✅ 0 💤 0 ❌
145 runs 145 ✅ 0 💤 0 ❌

Results for commit c6e48eb.

♻️ This comment has been updated with latest results.

Signed-off-by: Ivo Yankov <[email protected]>

…e-to-be-leveraged-for-sdk-testing

Signed-off-by: Ivo Yankov <[email protected]>

…e-to-be-leveraged-for-sdk-testing

Signed-off-by: Ivo Yankov <[email protected]>

codacy-production · 2024-09-24T11:30:28Z

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
Report missing for `538e40d`¹	✅ 73.53%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (`538e40d`)	Report Missing	Report Missing	Report Missing
Head commit (`c6e48eb`)	4175	3357	80.41%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#597)	170	125	73.53%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩

codecov · 2024-09-24T11:31:09Z

Codecov Report

Attention: Patch coverage is 73.17073% with 55 lines in your changes missing coverage. Please review.

Project coverage is 80.25%. Comparing base (5fa1b7d) to head (c6e48eb).
Report is 20 commits behind head on main.

Files with missing lines	Patch %	Lines
src/commands/node.mjs	66.43%	49 Missing ⚠️
src/core/helpers.mjs	91.37%	5 Missing ⚠️
test/test_util.js	0.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #597      +/-   ##
==========================================
- Coverage   80.83%   80.25%   -0.59%     
==========================================
  Files          37       37              
  Lines        4885     5014     +129     
  Branches      684      690       +6     
==========================================
+ Hits         3949     4024      +75     
- Misses        936      989      +53     
- Partials        0        1       +1

Files with missing lines	Coverage Δ
test/test_util.js	`87.26% <0.00%> (-3.90%)`	⬇️
src/core/helpers.mjs	`88.88% <91.37%> (+1.38%)`	⬆️
src/commands/node.mjs	`77.93% <66.43%> (-2.51%)`	⬇️

Signed-off-by: Ivo Yankov <[email protected]>

…e-to-be-leveraged-for-sdk-testing

.github/workflows/flow-pull-request-checks.yaml

jeromy-cannon

see comments

.github/workflows/zxc-code-analysis.yaml

src/commands/node.mjs

…e-to-be-leveraged-for-sdk-testing Signed-off-by: Jeffrey Tang <[email protected]>

…e-to-be-leveraged-for-sdk-testing Signed-off-by: Jeffrey Tang <[email protected]> # Conflicts: # src/commands/node.mjs # src/core/helpers.mjs

Signed-off-by: Jeffrey Tang <[email protected]>

github-actions · 2024-09-30T22:20:44Z

E2E Test Report

0 tests 0 ✅ 0s ⏱️
0 suites 0 💤
0 files 0 ❌

Results for commit c6e48eb.

github-actions · 2024-09-30T22:20:46Z

E2E Test Report

0 tests 0 ✅ 0s ⏱️
0 suites 0 💤
0 files 0 ❌

Results for commit c6e48eb.

## [0.31.0](v0.30.1...v0.31.0) (2024-10-04) ### Features * Add '--mirror-node-version' flag to override default mirror node version ([#616](#616)) ([e4932c4](e4932c4)) * add quiet flag ([#621](#621)) ([b068c8f](b068c8f)) * convert hugo docs workflow calls to use Taskfile task ([#642](#642)) ([ae8d8bb](ae8d8bb)) * ensured user-provided values file takes precedence over solo-generated values ([#615](#615)) ([1b0ffc9](1b0ffc9)) * **logging:** Add the new custom process output class and inject it into the default list renderer options ([#622](#622)) ([efa1783](efa1783)) * separate commands for solo node delete ([#597](#597)) ([b251276](b251276)) * Separate network upgrade and freeze from node update/add/delete command ([#628](#628)) ([9b17937](9b17937)) ### Bug Fixes * Direct calling of node stop and start commands ([#636](#636)) ([7749b04](7749b04)) * **docs:** resolve issues due to npx in taskfile for the custom-network-config example ([038e6df](038e6df)) * jsdoc failed but ci job not failed ([#608](#608)) ([3f838f6](3f838f6)) * specify jvm env variables explicitly for local profile ([#405](#405)) ([3db7e08](3db7e08)) * **tests:** start Kind cluster on demand if not having a kube config errors ([#624](#624)) ([538e40d](538e40d)) * upgrade eslint config away from abandoned plugin ([#643](#643)) ([84d3dc5](84d3dc5))

swirlds-automation · 2024-10-04T16:32:54Z

🎉 This PR is included in version 0.31.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Ivo-Yankov added 3 commits September 18, 2024 11:40

wip: separate commands for delete

0896483

Signed-off-by: Ivo Yankov <[email protected]>

Merge branch 'main' into 00529-reusable-components-of-solo-node-delet…

ef0c3dc

…e-to-be-leveraged-for-sdk-testing

test: add new CI

641e54b

Signed-off-by: Ivo Yankov <[email protected]>

Ivo-Yankov added 2 commits September 18, 2024 15:35

chore: add parser functions

320228f

Signed-off-by: Ivo Yankov <[email protected]>

wip: add new commands

4016963

Signed-off-by: Ivo Yankov <[email protected]>

jeromy-cannon assigned Ivo-Yankov Sep 19, 2024

Ivo-Yankov added 9 commits September 20, 2024 11:50

fix: delete commands

e9e1484

Signed-off-by: Ivo Yankov <[email protected]>

Merge branch 'main' into 00529-reusable-components-of-solo-node-delet…

29d4afc

…e-to-be-leveraged-for-sdk-testing

fix: formatting

325b34d

Signed-off-by: Ivo Yankov <[email protected]>

fix: failing test

5788697

Signed-off-by: Ivo Yankov <[email protected]>

fix: failing test

58ea09e

Signed-off-by: Ivo Yankov <[email protected]>

chore: debug test

9eae6af

Signed-off-by: Ivo Yankov <[email protected]>

Merge branch 'main' into 00529-reusable-components-of-solo-node-delet…

b9f77cb

…e-to-be-leveraged-for-sdk-testing

fix: e2e test

6990fc8

Signed-off-by: Ivo Yankov <[email protected]>

fix: e2e test

dd386d5

Signed-off-by: Ivo Yankov <[email protected]>

Ivo-Yankov marked this pull request as ready for review September 24, 2024 11:52

Ivo-Yankov requested review from a team and leninmehedy as code owners September 24, 2024 11:52

Ivo-Yankov added 2 commits September 24, 2024 14:53

nit: formatting

d2c5c5e

Signed-off-by: Ivo Yankov <[email protected]>

Merge branch 'main' into 00529-reusable-components-of-solo-node-delet…

2819d9b

…e-to-be-leveraged-for-sdk-testing

jeromy-cannon reviewed Sep 30, 2024

View reviewed changes

.github/workflows/flow-pull-request-checks.yaml Outdated Show resolved Hide resolved

jeromy-cannon requested changes Sep 30, 2024

View reviewed changes

JeffreyDallas reviewed Sep 30, 2024

View reviewed changes

.github/workflows/zxc-code-analysis.yaml Show resolved Hide resolved

JeffreyDallas reviewed Sep 30, 2024

View reviewed changes

src/commands/node.mjs Outdated Show resolved Hide resolved

src/commands/node.mjs Outdated Show resolved Hide resolved

src/commands/node.mjs Outdated Show resolved Hide resolved

Merge branch 'main' into 00529-reusable-components-of-solo-node-delet…

6e97465

…e-to-be-leveraged-for-sdk-testing Signed-off-by: Jeffrey Tang <[email protected]>

JeffreyDallas added 3 commits September 30, 2024 14:55

Merge branch 'main' into 00529-reusable-components-of-solo-node-delet…

57b9283

…e-to-be-leveraged-for-sdk-testing Signed-off-by: Jeffrey Tang <[email protected]> # Conflicts: # src/commands/node.mjs # src/core/helpers.mjs

fix missing steps

2dacfd8

Signed-off-by: Jeffrey Tang <[email protected]>

fix

c6e48eb

Signed-off-by: Jeffrey Tang <[email protected]>

jeromy-cannon approved these changes Oct 1, 2024

View reviewed changes

jeromy-cannon merged commit b251276 into main Oct 1, 2024
34 of 37 checks passed

jeromy-cannon deleted the 00529-reusable-components-of-solo-node-delete-to-be-leveraged-for-sdk-testing branch October 1, 2024 11:59

swirlds-automation added the released label Oct 4, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: separate commands for solo node delete #597

feat: separate commands for solo node delete #597

Ivo-Yankov commented Sep 18, 2024 •

edited

Loading

github-actions bot commented Sep 18, 2024 •

edited

Loading

github-actions bot commented Sep 18, 2024 •

edited

Loading

codacy-production bot commented Sep 24, 2024 •

edited

Loading

codecov bot commented Sep 24, 2024 •

edited

Loading

jeromy-cannon left a comment

github-actions bot commented Sep 30, 2024

github-actions bot commented Sep 30, 2024

swirlds-automation commented Oct 4, 2024

feat: separate commands for solo node delete #597

feat: separate commands for solo node delete #597

Conversation

Ivo-Yankov commented Sep 18, 2024 • edited Loading

Description

Related Issues

github-actions bot commented Sep 18, 2024 • edited Loading

Unit Test Results - Linux

github-actions bot commented Sep 18, 2024 • edited Loading

Unit Test Results - Windows

codacy-production bot commented Sep 24, 2024 • edited Loading

Coverage summary from Codacy

See diff coverage on Codacy

See your quality gate settings Change summary preferences

Footnotes

codecov bot commented Sep 24, 2024 • edited Loading

Codecov Report

jeromy-cannon left a comment

Choose a reason for hiding this comment

github-actions bot commented Sep 30, 2024

E2E Test Report

github-actions bot commented Sep 30, 2024

E2E Test Report

swirlds-automation commented Oct 4, 2024

Ivo-Yankov commented Sep 18, 2024 •

edited

Loading

github-actions bot commented Sep 18, 2024 •

edited

Loading

github-actions bot commented Sep 18, 2024 •

edited

Loading

codacy-production bot commented Sep 24, 2024 •

edited

Loading

codecov bot commented Sep 24, 2024 •

edited

Loading