Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update @hashgraph\sdk once log file PR gets released #331

Closed
4 of 5 tasks
Tracked by #50
jeromy-cannon opened this issue May 29, 2024 · 1 comment · Fixed by #391
Closed
4 of 5 tasks
Tracked by #50

update @hashgraph\sdk once log file PR gets released #331

jeromy-cannon opened this issue May 29, 2024 · 1 comment · Fixed by #391
Assignees
Labels
Blocker Further development work cannot be done P2 Required to be completed in the assigned milestone, but may or may not impact release schedule. released

Comments

@jeromy-cannon
Copy link
Contributor

jeromy-cannon commented May 29, 2024

  • do an npm upgrade on @hashgraph/sdk
  • document in developers readme where to find the new ${constants.SOLO_LOGS_DIR}/hashgraph-sdk.log and what is in it
  • update e2e workflow to upload ${constants.SOLO_LOGS_DIR}/hashgraph-sdk.log
  • update logic for setting node client sdk logger
    accountManager.mjs:
      // TODO: need updated version of SDK to set log file, once it is writing to the file, we can remove the if devMode check and just always set it:
      if (this.logger.devMode) {
        this._nodeClient.setLogger(new Logger(LogLevel.Trace, `${constants.SOLO_LOGS_DIR}/hashgraph-sdk.log`))
      }

to:

      this._nodeClient.setLogger(new Logger(LogLevel.Trace, `${constants.SOLO_LOGS_DIR}/hashgraph-sdk.log`))
@jeromy-cannon jeromy-cannon self-assigned this May 29, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in Solo May 29, 2024
@jeromy-cannon jeromy-cannon moved this from 🆕 New to 📋 Backlog in Solo May 29, 2024
@jeromy-cannon jeromy-cannon added P2 Required to be completed in the assigned milestone, but may or may not impact release schedule. Blocker Further development work cannot be done labels May 31, 2024
@jeromy-cannon jeromy-cannon moved this from 📋 Backlog to 🔖 Ready in Solo May 31, 2024
@github-project-automation github-project-automation bot moved this from 🔖 Ready to ✅ Done in Solo Jun 18, 2024
@swirlds-automation
Copy link
Contributor

🎉 This issue has been resolved in version 0.28.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocker Further development work cannot be done P2 Required to be completed in the assigned milestone, but may or may not impact release schedule. released
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

3 participants