Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update hedera explorer chart version and location #1187

Merged
merged 7 commits into from
Jan 21, 2025

Conversation

nathanklick
Copy link
Member

Description

This pull request changes the following:

  • Updates the location and version of the Hedera Explorer chart
  • Renames two constants to fix typographical errors

Related Issues

@nathanklick nathanklick self-assigned this Jan 20, 2025
@nathanklick nathanklick requested review from leninmehedy and a team as code owners January 20, 2025 20:06
@nathanklick nathanklick changed the base branch from main to release/0.33 January 20, 2025 20:07
@nathanklick nathanklick changed the base branch from release/0.33 to main January 20, 2025 20:10
@nathanklick nathanklick changed the base branch from main to release/0.33 January 20, 2025 20:10
Copy link
Contributor

github-actions bot commented Jan 20, 2025

Unit Test Results - Linux

  1 files   58 suites   3s ⏱️
227 tests 227 ✅ 0 💤 0 ❌
232 runs  232 ✅ 0 💤 0 ❌

Results for commit 8db97cc.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jan 20, 2025

Unit Test Results - Windows

  1 files   58 suites   13s ⏱️
227 tests 227 ✅ 0 💤 0 ❌
232 runs  232 ✅ 0 💤 0 ❌

Results for commit 8db97cc.

♻️ This comment has been updated with latest results.

Copy link
Contributor

E2E Test Report

 16 files  121 suites   1h 20m 14s ⏱️
258 tests 258 ✅ 0 💤 0 ❌
261 runs  261 ✅ 0 💤 0 ❌

Results for commit 96d5aad.

Copy link
Contributor

github-actions bot commented Jan 21, 2025

E2E Test Report

 16 files  121 suites   1h 20m 22s ⏱️
258 tests 258 ✅ 0 💤 0 ❌
261 runs  261 ✅ 0 💤 0 ❌

Results for commit 8db97cc.

♻️ This comment has been updated with latest results.

Copy link

codacy-production bot commented Jan 21, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 3640e9a1 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (3640e9a) Report Missing Report Missing Report Missing
Head commit (8db97cc) 20809 17512 84.16%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1187) 8 8 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release/0.33@3640e9a). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##             release/0.33    #1187   +/-   ##
===============================================
  Coverage                ?   83.38%           
===============================================
  Files                   ?       77           
  Lines                   ?    20809           
  Branches                ?     1902           
===============================================
  Hits                    ?    17351           
  Misses                  ?     3308           
  Partials                ?      150           
Files with missing lines Coverage Δ
src/commands/mirror_node.ts 71.02% <100.00%> (ø)
src/core/constants.ts 97.34% <100.00%> (ø)
version.ts 100.00% <100.00%> (ø)

Impacted file tree graph

@nathanklick nathanklick merged commit 035741b into release/0.33 Jan 21, 2025
40 checks passed
swirlds-automation added a commit that referenced this pull request Jan 21, 2025
## [0.33.1](v0.33.0...v0.33.1) (2025-01-21)

### Bug Fixes

* update hedera explorer chart version and location ([#1187](#1187)) ([035741b](035741b))
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.33.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Hedera Explorer helm chart registry
2 participants