Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate the number of .env files that store the same values #767

Closed
SimiHunjan opened this issue Aug 22, 2024 · 2 comments
Closed

Consolidate the number of .env files that store the same values #767

SimiHunjan opened this issue Aug 22, 2024 · 2 comments
Labels
Backlog Work that needs to be done sometime in the future. No milestone assigned or not yet available.

Comments

@SimiHunjan
Copy link
Contributor

SimiHunjan commented Aug 22, 2024

Problem

There are a few locations where the following values are repeated:

# Postgres database
# service name for postgres service in docker
POSTGRES_HOST=database
POSTGRES_PORT=5432
POSTGRES_DATABASE=postgres
POSTGRES_USERNAME=postgres
POSTGRES_PASSWORD=postgres
# should be false in production
POSTGRES_SYNCHRONIZE=true

# PG Admin settings
[email protected]
PGADMIN_DEFAULT_PASSWORD=pgadmin4

NODE_ENV=development

API: https://github.com/hashgraph/hedera-transaction-tool/blob/main/back-end/apps/api/.env.test
Chain: https://github.com/hashgraph/hedera-transaction-tool/blob/main/back-end/apps/chain/example.env
Notifications: https://github.com/hashgraph/hedera-transaction-tool/blob/main/back-end/apps/notifications/example.env
backend Root: https://github.com/hashgraph/hedera-transaction-tool/blob/main/back-end/example.env


### Solution

It seems it would make sense to house these values in one location to call from vs. in multiple locations. 

### Alternatives

_No response_
@SimiHunjan
Copy link
Contributor Author

It is not important for now but logging this to review in the future.

@SimiHunjan SimiHunjan added the Backlog Work that needs to be done sometime in the future. No milestone assigned or not yet available. label Aug 27, 2024
@RAMTO
Copy link
Contributor

RAMTO commented Aug 27, 2024

@SimiHunjan Using microservices for the BE requires using different .env files and some of the variables could be duplicated. As discussed with @SvetBorislavov it will be very difficult to consolidate these variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backlog Work that needs to be done sometime in the future. No milestone assigned or not yet available.
Projects
None yet
Development

No branches or pull requests

2 participants