Hapi module build doesn't recognize services tags

[mhess-swl]

Description

When building the hapi module (with gradle), I expect the branchOrTag variable here to recognize, build, and incorporate tags created in the hedera-protobufs repo. However, building the hapi module currently either 1) fails or 2) does not include the changes with said tag (if no compiler change is needed)

Steps to reproduce

• Make a change in the hedera-protobufs repo, e.g. add a new grpc endpoint getXInfo
• Open a PR with getXInfo to the hedera-protobufs repo, then merge the PR
• Create a git tag that includes getXInfo
• Modify the branchOrTag variable in the hedera-services repo to the tag from the previous step, e.g. branchOrTag = "protobuf-tag_v0.91.0"
• In HapiUtils#functionOf(Query) (services repo), add a new case to the switch statement, e.g. case GET_X_INFO -> HederaFunctionality.GET_X_INFO;
• Attempt to build the hapi module (or the services project) with ./gradlew assemble. The gradle build will fail with a compilation error because it does not download and incorporate the new protobuf tag, protobuf-tag_v0.91.0

Additional context

According to @jjohannes, the issue is in this line: tags can't have the origin/ prefix. Removing origin/ from this code seems to fix the problem, but I'm not sure what other parts of the build might break as a result.

Hedera network

other

Version

I believe this happens with the current develop branch (commit 8ada1851a)

Operating system

macOS

[jjohannes]

Thanks for creating this issue. I can look into this.

[jjohannes]

PR that solves this by letting you explicitly define a "tag" OR a "branch: #13051

[mhess-swl]

Thanks for fixing this @jjohannes! 🙏