Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: set codecov config #2575

Merged
merged 1 commit into from
Oct 11, 2024
Merged

ci: set codecov config #2575

merged 1 commit into from
Oct 11, 2024

Conversation

ivaylonikolov7
Copy link
Contributor

@ivaylonikolov7 ivaylonikolov7 commented Oct 10, 2024

Description:
Adds a codecov config file - codecov.yaml that sets test coverage threshold and target

Related issue(s):
#2574

Fixes
partially #2574

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Ivaylo Nikolov <[email protected]>
@ivaylonikolov7 ivaylonikolov7 force-pushed the feat/set-codecov-config branch from 148c3d8 to 6e71545 Compare October 10, 2024 21:26
Copy link

@ivaylonikolov7 ivaylonikolov7 changed the title Feat/set codecov config feat: set codecov config Oct 10, 2024
@ivaylonikolov7 ivaylonikolov7 changed the title feat: set codecov config ci: set codecov config Oct 10, 2024
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.44%. Comparing base (10dfd3f) to head (6e71545).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2575      +/-   ##
==========================================
- Coverage   84.45%   84.44%   -0.01%     
==========================================
  Files         283      283              
  Lines       71038    71038              
==========================================
- Hits        59993    59988       -5     
- Misses      11045    11050       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@andrewb1269hg andrewb1269hg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Contributor

@agadzhalov agadzhalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ivaylonikolov7 ivaylonikolov7 merged commit 734aa62 into main Oct 11, 2024
13 checks passed
@ivaylonikolov7 ivaylonikolov7 deleted the feat/set-codecov-config branch October 11, 2024 15:04
b-l-u-e pushed a commit to b-l-u-e/hedera-sdk-js that referenced this pull request Oct 13, 2024
Signed-off-by: Ivaylo Nikolov <[email protected]>
Signed-off-by: b-l-u-e <[email protected]>
b-l-u-e pushed a commit to b-l-u-e/hedera-sdk-js that referenced this pull request Oct 13, 2024
Signed-off-by: Ivaylo Nikolov <[email protected]>
Signed-off-by: b-l-u-e <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants