feat(TCK): Add AccountCreate method #2476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ivaylogarnev-limechain <[email protected]>
ivaylogarnev-limechain
requested review from
rwalworth,
ivaylonikolov7,
0xivanov and
agadzhalov
ivaylogarnev-limechain
changed the title
0xivanov
reviewed
Aug 22, 2024
…moved some functions outside Key method. Signed-off-by: ivaylogarnev-limechain <[email protected]>
…t interface Signed-off-by: ivaylogarnev-limechain <[email protected]>
0xivanov
reviewed
Aug 23, 2024
0xivanov
reviewed
Aug 26, 2024
|
Btw the DCO fails. I would recommend you to sign it now so you wouldn't have to do some git gymnastics to sign non-last commits. |
…ed account method Signed-off-by: ivaylogarnev-limechain <[email protected]>
ivaylogarnev-limechain
force-pushed
the
feat/2433-tck-account-create
branch
from
d6cbbae to
263ec3d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2476 +/- ##
=======================================
Coverage 75.82% 75.82%
=======================================
Files 237 237
Lines 60072 60072
=======================================
Hits 45552 45552
Misses 14520 14520 ☔ View full report in Codecov by Sentry. |
|
btw I just noticed that one of the commits isn't signed. The DCO passes but when we merge to main there is going to be a problem. |
…processKeyRecursively method Signed-off-by: ivaylogarnev-limechain <[email protected]>
ivaylogarnev-limechain
force-pushed
the
feat/2433-tck-account-create
branch
from
b7c3c9b to
8c53c25
Compare
…stom enum, refactored getEvmAddressFromKey, getKeyFromString, handleEd25519andEcdsa methods and SDK setup Signed-off-by: ivaylogarnev-limechain <[email protected]>
ivaylogarnev-limechain
force-pushed
the
feat/2433-tck-account-create
branch
from
8c53c25 to
8499ef6
Compare
|
0xivanov
approved these changes
Aug 28, 2024
Merged
ivaylogarnev-limechain
added a commit
that referenced
this pull request
Sep 19, 2024
* feat: Added TCK server json-rpc methods for account create transaction Signed-off-by: ivaylogarnev-limechain <[email protected]> * fix: Renamed some interfaces, refactored processKeyRecursively func, moved some functions outside Key method. Signed-off-by: ivaylogarnev-limechain <[email protected]> * fix: Splitted models folder into params/response and renamed the Input interface Signed-off-by: ivaylogarnev-limechain <[email protected]> * fix: Removed unnecessary async, introduced CustomError class, refacoted account method Signed-off-by: ivaylogarnev-limechain <[email protected]> * refactor: Removed logs, unnecessary error handling logic, refactored processKeyRecursively method Signed-off-by: ivaylogarnev-limechain <[email protected]> * refactor: Introduced asn1DecodedKey interface and JSONRPCErrorCode custom enum, refactored getEvmAddressFromKey, getKeyFromString, handleEd25519andEcdsa methods and SDK setup Signed-off-by: ivaylogarnev-limechain <[email protected]> --------- Signed-off-by: ivaylogarnev-limechain <[email protected]>
This was referenced Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR implements the TCK JSON-RPC server using TypeScript. Developed and integrated the AccountCreate method, and successfully validated its functionality through comprehensive tests within the TCK project.
Related issue(s):
#2433
Checklist