Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: updated for best practices #2260

Merged

Conversation

rbarkerSL
Copy link
Contributor

Description:
Updating workflows as part of the CI audit on hashgraph org repos.

Related issue(s):

Fixes #2243

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@rbarkerSL rbarkerSL requested a review from nathanklick April 11, 2024 19:47
@rbarkerSL rbarkerSL self-assigned this Apr 11, 2024
@rbarkerSL rbarkerSL linked an issue Apr 11, 2024 that may be closed by this pull request
@SimiHunjan SimiHunjan added this to the 2.45.0 milestone Apr 16, 2024
@svetoslav-nikol0v svetoslav-nikol0v modified the milestones: 2.45.0, 2.46.0 Apr 29, 2024
Signed-off-by: Roger Barker <[email protected]>
Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.26%. Comparing base (5c428d4) to head (d83ef2f).
Report is 64 commits behind head on main.

Current head d83ef2f differs from pull request most recent head 7b52b01

Please upload reports for the commit 7b52b01 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2260      +/-   ##
==========================================
+ Coverage   76.49%   84.26%   +7.76%     
==========================================
  Files         304       53     -251     
  Lines       75800    11432   -64368     
==========================================
- Hits        57986     9633   -48353     
+ Misses      17814     1799   -16015     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Show resolved Hide resolved
@SimiHunjan SimiHunjan modified the milestones: 2.45.0, 2.46.0 May 14, 2024
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
Signed-off-by: Roger Barker <[email protected]>
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@rbarkerSL rbarkerSL requested a review from nathanklick May 21, 2024 14:59
@rbarkerSL rbarkerSL merged commit ae33e64 into main May 21, 2024
9 checks passed
@rbarkerSL rbarkerSL deleted the 2243-update-ci-workflows-for-best-practices-and-standards branch May 21, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update ci workflows for best practices and standards
6 participants