Add support for Long and BigNumber to the array methods of ContractFunctionParameters #2013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svetoslav-nikol0v
requested review from
SimiHunjan,
ochikov and
petreze
as code owners
Signed-off-by: svetoslav-nikol0v <[email protected]>
Signed-off-by: svetoslav-nikol0v <[email protected]>
Signed-off-by: svetoslav-nikol0v <[email protected]>
Signed-off-by: svetoslav-nikol0v <[email protected]>
Signed-off-by: svetoslav-nikol0v <[email protected]>
Signed-off-by: svetoslav-nikol0v <[email protected]>
svetoslav-nikol0v
force-pushed
the
1976-uint256array-on-contract-function-arguments-expecting-number-instead-of-bignumber
branch
from
36ab7d2 to
e21f985
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #2013 +/- ##
===========================================
+ Coverage 76.94% 84.16% +7.22%
===========================================
Files 292 304 +12
Lines 72743 75863 +3120
===========================================
+ Hits 55971 63851 +7880
+ Misses 16772 12012 -4760 ☔ View full report in Codecov by Sentry. |
Signed-off-by: svetoslav-nikol0v <[email protected]>
Signed-off-by: svetoslav-nikol0v <[email protected]>
Signed-off-by: svetoslav-nikol0v <[email protected]>
ochikov
approved these changes
Nov 6, 2023
…ctFunctionParameters array methods (#2016) * adding an initial value of the reduce method + tests Signed-off-by: svetoslav-nikol0v <[email protected]> * remove .only Signed-off-by: svetoslav-nikol0v <[email protected]> * adding test for when methods fail Signed-off-by: svetoslav-nikol0v <[email protected]> * using const Signed-off-by: svetoslav-nikol0v <[email protected]> --------- Signed-off-by: svetoslav-nikol0v <[email protected]> Signed-off-by: ochikov <[email protected]>
ochikov
force-pushed
the
1976-uint256array-on-contract-function-arguments-expecting-number-instead-of-bignumber
branch
from
da10ed5 to
d64abdb
Compare
|
SonarCloud Quality Gate failed.
|
svetoslav-nikol0v
deleted the
1976-uint256array-on-contract-function-arguments-expecting-number-instead-of-bignumber
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related issue(s):
Fixes #1976
Checklist