Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix operator and operator account id override in beforeExecute #1531

Merged
merged 2 commits into from
Mar 30, 2023

Conversation

dikel
Copy link
Contributor

@dikel dikel commented Mar 28, 2023

Description:
Fixes the override of operator and operatorAccountId in Transaction._beforeExecute(). This was causing the transaction to fail when using a wallet as a signer.

Related issue(s):

Fixes #1530

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: dikel <[email protected]>
@ochikov ochikov merged commit 857dda5 into develop Mar 30, 2023
@ochikov ochikov deleted the fix/operator-overridden-in-before-execute branch March 30, 2023 11:30
monokaijs pushed a commit to monostarter/u2u-sdk-js that referenced this pull request Jul 5, 2023
…-ledger#1531)

* Fix operator and operator account id override in Transaction._beforeExecute

Signed-off-by: dikel <[email protected]>

* fix tests

Signed-off-by: dikel <[email protected]>

---------

Signed-off-by: dikel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

_operator and _operatorAccountId are overridden in Transaction._beforeExecute
2 participants