Fix examples build warnings #1475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Petar Tonev <[email protected]>
Signed-off-by: Petar Tonev <[email protected]>
Signed-off-by: Petar Tonev <[email protected]>
Signed-off-by: ochikov <[email protected]>
Signed-off-by: Petar Tonev <[email protected]>
Signed-off-by: Petar Tonev <[email protected]>
Signed-off-by: Petar Tonev <[email protected]>
ochikov
approved these changes
Feb 27, 2023
monokaijs
pushed a commit
to monostarter/u2u-sdk-js
that referenced
this pull request
Jul 5, 2023
* partial work Signed-off-by: Petar Tonev <[email protected]> * init hip583 Signed-off-by: Petar Tonev <[email protected]> * full support Signed-off-by: Petar Tonev <[email protected]> * fix example for nft allowances Signed-off-by: ochikov <[email protected]> * partial Signed-off-by: Petar Tonev <[email protected]> * remove warnings from 2 tests Signed-off-by: Petar Tonev <[email protected]> * fix all example warnings Signed-off-by: Petar Tonev <[email protected]> --------- Signed-off-by: Petar Tonev <[email protected]> Signed-off-by: ochikov <[email protected]> Co-authored-by: ochikov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes all build warnings in the examples plus getting account infos from the mirror node for deprecated fields (or soon to be deprecated) instead of using
AccountInfoQueryRelated issue(s):
Fixes #1473 #1474
Notes for reviewer:
All warnings inside the examples are fixed. Furthermore, in the cases where there will be deprecation in
AccountInfoQueryfields, we are now using the information provided from the mirror nodeChecklist