Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Husky package #2565

Closed
ivaylogarnev-limechain opened this issue Oct 7, 2024 · 1 comment · May be fixed by #2596
Closed

Integrate Husky package #2565

ivaylogarnev-limechain opened this issue Oct 7, 2024 · 1 comment · May be fixed by #2596
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@ivaylogarnev-limechain
Copy link
Contributor

ivaylogarnev-limechain commented Oct 7, 2024

Problem

Occasionally, contributors may unintentionally skip signing their commits, which can lead to significant challenges down the road, especially when managing complex pull requests with contributions from multiple people. If several commits are missing the required sign-off, it can create unnecessary complications during the merge process, ultimately increasing the time and effort needed to resolve the issue.

Solution

A potential solution to this problem is to leverage the Husky npm package. Husky can be configured to enforce signing off on commits and ensure that necessary pre-commit tasks, such as running linters or other validation scripts, are executed before the commit is finalized. This tool helps maintain code quality by automatically running tasks like linting or throwing an error if you try to commit without signing it.

@ivaylogarnev-limechain ivaylogarnev-limechain added the enhancement New feature or request label Oct 7, 2024
@ivaylogarnev-limechain ivaylogarnev-limechain self-assigned this Oct 7, 2024
@SimiHunjan SimiHunjan added this to the v2.53.0 milestone Oct 15, 2024
@ivaylogarnev-limechain ivaylogarnev-limechain linked a pull request Oct 28, 2024 that will close this issue
2 tasks
@ivaylogarnev-limechain
Copy link
Contributor Author

After implementing the Husky package and configuring it in a PR, we consulted with our DevOps team to enable a setting to complete the desired functionality. During this process, we discussed the use of Husky, and the team expressed strong reservations about its use. Based on their feedback, we’ve decided not to merge the PR with Husky. They recommended using the pre-commit tool as a more suitable alternative, which can achieve our goals. We’ve noted this and plan to implement it when we have the opportunity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants