Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functions for remove/clear signatures #2461

Closed
jbair06 opened this issue Aug 20, 2024 · 0 comments · Fixed by #2491
Closed

Add functions for remove/clear signatures #2461

jbair06 opened this issue Aug 20, 2024 · 0 comments · Fixed by #2491
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@jbair06
Copy link
Member

jbair06 commented Aug 20, 2024

Problem

Once a signature has been added via addSignature, there is no convenience method to remove the signature.

Removing signatures is helpful when a transaction has a signing account that has a large keylist with many thresholds. If all signatures added to the transaction result in a transaction too large to submit, then only the minimum number of signatures required to make the transaction valid should be added to the transaction.

Also, if a signature is added, the owner of the key might decide to revoke the signature. Without recreating the transaction and re adding all the signatures, this is not possible.

Solution

  • Add removeSignature(publicKey/signature) method
  • Add clearSignatures() method

These two convenience methods will be helpful to remove signatures as needed.

Alternatives

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants