Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle platform_not_active error gracefully #2353

Closed
SimiHunjan opened this issue Jun 14, 2024 · 1 comment · Fixed by #2401
Closed

Handle platform_not_active error gracefully #2353

SimiHunjan opened this issue Jun 14, 2024 · 1 comment · Fixed by #2401
Assignees
Labels
enhancement New feature or request p3
Milestone

Comments

@SimiHunjan
Copy link
Contributor

Problem

The SDK offers a convenience feature where when a transaction is signed by the user it will pre-sign transactions for 1/3 of the nodes in the network. This is to provide redundancy in cases where a transaction could fail and can pick up the next signed transaction to a different node. A transaction cannot be sent to all nodes as the signed transaction requires you to specify a single node before user the signs the transaction. If there was not such a feature you would imagine that the user would have to be pinged to resign another transaction each time it tries to send the transaction to a different node.

In some cases, this feature could provide an unwanted outcome in that the first transaction it tries that node could return an error to the user while it is trying to submit the following transaction to a different node. The user would then observe that their transaction failed (true for the first transaction), but was actually successful (when it got submitted to the next node).

This issue is to investigate the above scenario and see if there are ways to improve this experience so that the user does not get mislead. Also to give guidance to developers on how their apps should account for this scenario.

This example provided that kicked off this discussion is the following:

Receiving a PLATFORM_NOT_ACTIVE error node a node. At the time this was received we believe this from a node that was marked as degraded. The the following the transaction was successful on the explorer

https://hashscan.io/mainnet/transaction/1718307329.984046337

image (17)

Solution

Research potential ways to improve and provide guidance to developers for how to manage these cases.

Alternatives

No response

@SimiHunjan SimiHunjan added the enhancement New feature or request label Jun 14, 2024
@SimiHunjan
Copy link
Contributor Author

@teacoat the team looked into this issue and is planning to implement an enhancement where the platform not active error will handled in a way that the error won't be thrown to the user in the future

@SimiHunjan SimiHunjan changed the title Discussion: Node selection feature Handle platform_not_active error gracefully Jun 25, 2024
@SimiHunjan SimiHunjan added this to the 2.49.0 milestone Jun 25, 2024
@SimiHunjan SimiHunjan added the p3 label Jun 25, 2024
@svetoslav-nikol0v svetoslav-nikol0v self-assigned this Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request p3
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants