Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HIP-646: Fungible Token Metadata Field #1736

Closed
1 of 9 tasks
Tracked by #130
SimiHunjan opened this issue Jul 25, 2023 · 3 comments · Fixed by #2210
Closed
1 of 9 tasks
Tracked by #130

Add HIP-646: Fungible Token Metadata Field #1736

SimiHunjan opened this issue Jul 25, 2023 · 3 comments · Fixed by #2210
Assignees
@svetoslav-nikol0v
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request good first issue Issues which are ideal for a first time or new project contributor. p1 protobuf Feature depends on Hedera protobuf specification services Feature depends on Hedera Services node software support
Milestone
2.45.0-beta.1

Comments

@SimiHunjan
Copy link
Contributor

SimiHunjan commented Jul 25, 2023 •
edited by svetoslav-nikol0v
Loading

Problem

HIP-646 introduces new Hedera protobuf changes where the a token metadata field is added to the TokenCreateTransaction and TokenUpdateTransaction. This metadata field will also be returned in the TokenInfoQuery.

HIP

Hedera Protobuf

  • (link Hedera protobuf PR when available)

Hedera Services Release

  • 0.42

Summary of API changes

  • Add metadata field to TokenCreateTransaction
  • Add metadata field to TokenUpdateTransaction
  • Return the metadata of a token from the TokenInfoQuery

Solution

Alternatives

No response
@SimiHunjan SimiHunjan added the enhancement New feature or request label Jul 25, 2023
@SimiHunjan
Copy link
Contributor Author

Update: This feature will be added in the 0.42 October mainnet release. Could be pushed to the next release if modularization work is not complete.

@SimiHunjan
Copy link
Contributor Author

Update: This is being pushed to 0.43 Services release.

@ghost
Copy link

ghost commented Nov 29, 2023

Could you kindly share your expectation regarding when HIP-646 might be integrated into the SDK

@SimiHunjan SimiHunjan added services Feature depends on Hedera Services node software support protobuf Feature depends on Hedera protobuf specification dependencies Pull requests that update a dependency file good first issue Issues which are ideal for a first time or new project contributor. labels Jan 2, 2024
@SimiHunjan SimiHunjan added this to the 2.43.0 milestone Feb 29, 2024
@SimiHunjan SimiHunjan mentioned this issue Feb 29, 2024
Open
@SimiHunjan SimiHunjan added the p1 label Mar 5, 2024
@svetoslav-nikol0v svetoslav-nikol0v self-assigned this Mar 18, 2024
@svetoslav-nikol0v svetoslav-nikol0v mentioned this issue Mar 18, 2024
Merged
2 tasks
@SimiHunjan SimiHunjan modified the milestones: 2.43.0, 2.44.0 Mar 18, 2024
@Petyo-Lukanov Petyo-Lukanov linked a pull request Mar 20, 2024 that will close this issue
feature: update metadata field of fungible and non-fungible tokens, and dynamic NFTs #2210
Merged
2 tasks
@SimiHunjan SimiHunjan modified the milestones: 2.44.0, 2.45.0 Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@svetoslav-nikol0v svetoslav-nikol0v

Labels
dependencies Pull requests that update a dependency file enhancement New feature or request good first issue Issues which are ideal for a first time or new project contributor. p1 protobuf Feature depends on Hedera protobuf specification services Feature depends on Hedera Services node software support
Projects
None yet
Milestone
2.45.0-beta.1
2 participants
@SimiHunjan @svetoslav-nikol0v