chore: respect submodule SHA references on submodule init (#2454)

* chore: respect submodule SHA references on submodule init Signed-off-by: Iliya Savov <[email protected]> * chore: match repository checkout settings accross workflows Signed-off-by: Iliya Savov <[email protected]> --------- Signed-off-by: Iliya Savov <[email protected]> Co-authored-by: Iliya Savov <[email protected]>
hiero-ledger · Aug 22, 2024 · 202f328 · 202f328
1 parent f930c0e
commit 202f328
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/.github/workflows/publish_release.yaml b/.github/workflows/publish_release.yaml
@@ -59,6 +59,7 @@ jobs:
         with:
           ref: ${{ github.event.inputs.tag || '' }}
           fetch-depth: 0
+          submodules: recursive
 
       - name: Install Semantic Version Tools
         run: |
@@ -238,6 +239,7 @@ jobs:
         uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
         with:
           ref: ${{ github.event.inputs.tag || '' }}
+          submodules: recursive
 
       - name: Install Task
         uses: arduino/setup-task@b91d5d2c96a56797b48ac1e0e89220bf64044611 # v2.0.0
@@ -274,6 +276,7 @@ jobs:
         uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
         with:
           ref: ${{ github.event.inputs.tag || '' }}
+          submodules: recursive
 
       - name: Install Task
         uses: arduino/setup-task@b91d5d2c96a56797b48ac1e0e89220bf64044611 # v2.0.0

diff --git a/packages/proto/Taskfile.yml b/packages/proto/Taskfile.yml
@@ -19,12 +19,7 @@ tasks:
 
     "install:submodules":
         cmds:
-            # TODO: How do we support this build step when we update the
-            # protobufs? Currently, this step results in reseting any protobuf
-            # updates we may have.
-            #- git submodule update --init
-            # using tag --remote in order to always apply the newest proto changes
-            - git submodule update --init --remote
+            - git submodule update --init
         status:
             - test -e src/proto/.git