Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GRPC health check #476

Closed
steven-sheehy opened this issue Jan 2, 2020 · 2 comments · Fixed by #514
Closed

GRPC health check #476

steven-sheehy opened this issue Jan 2, 2020 · 2 comments · Fixed by #514
Assignees
Labels
enhancement Type: New feature grpc Area: GRPC API P1
Milestone

Comments

@steven-sheehy
Copy link
Member

Problem
Ops requested a health check API to monitor the new GRPC component

Solution
Add a GRPC endpoint that provides health status of the component

Alternatives

  • Monitor logs
  • Add to monitor service
  • Add a REST endpoint to GRPC process

Additional Context

@steven-sheehy steven-sheehy added enhancement Type: New feature P2 grpc Area: GRPC API labels Jan 2, 2020
@steven-sheehy steven-sheehy added this to the Mirror 0.5.1 milestone Jan 2, 2020
@steven-sheehy steven-sheehy self-assigned this Jan 2, 2020
@steven-sheehy steven-sheehy changed the title GRPC health checks GRPC health check Jan 2, 2020
@steven-sheehy
Copy link
Member Author

Turns out this is already implemented by Spring Boot GRPC and using standard GRPC health check API:

$ grpcurl -plaintext -d '{"service":"com.hedera.mirror.api.proto.ConsensusService"}' localhost:5600 grpc.health.v1.Health/Check
{
  "status": "SERVING"
}

To watch for changes instead of polling:

$ grpcurl -plaintext -d '{"service":"com.hedera.mirror.api.proto.ConsensusService"}' localhost:5600 grpc.health.v1.Health/Watch
{
  "status": "SERVING"
}

@steven-sheehy steven-sheehy added the wontfix This will not be worked on label Jan 4, 2020
@steven-sheehy
Copy link
Member Author

Reopening as Ops' pingdom is unable to take advantage of the GRPC or HTTP/2 based health check endpoint. We will have to implement a REST based health check for this component

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Type: New feature grpc Area: GRPC API P1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant