Override default max gas refund property for some environments #408
Labels
Good first issue
Good for newcomers
hacktoberfest
Issues shown by lists for the Hacktoberfest and made for newcomers to do the first contribution.
🆕🐥 First Timers Only
This issue is reserved for people who have never contributed to Hedera or any open source project in general.
We know that creating a pull request (PR) is a major barrier for new contributors.
The goal of this issue and all other issues labeled by 'Good First Issue' is to help you make your first contribution to Hedera.
👾 Description of the issue
Currently, when we process a transaction in the consensus node we populate a field in the transaction receipt, called
gasUsed
which is the larger number of the pair: 1. the actually consumed gas by the EVM and 2.gasLimit
- 20% ofgasLimit
for the transaction.The 20% of total gas limit max refund is configurable by an application property on the consensus node called
contracts.maxRefundPercentOfGasLimit
.In order for devs to be able to see the actual gas used (regardless of the max refund logic), add custom manual configuration on local node by changing the global dynamic property maxGasRefundPercentage property from 20 to 100. This would eliminate the refund policy in the consensus node and the gasUsed field would take the actually gas consumed value.
Proposed Solution:
Add the
contracts.maxRefundPercentOfGasLimit
property incompose-network/network-node/application.properties
and set its value to 100.📋 Step by step guide to do a contribution
If you have never contributed to an open source project at GitHub, the following step-by-step guide will introduce you to the workflow. More information and concrete samples for shell commands for each step can be found in our CONTRIBUTING.md file.
A more detailed general documentation of the GitHub PR workflow can be found here.
sign-off
information to the commit to accept the "Developer Certificate of Origin" (https://developercertificate.org). More details can be found in our CONTRIBUTING.md🎉 Contribute to Hacktoberfest
Solve this issue as part of the Hacktoberfest event and get a chance to receive cool goodies like a T-Shirt. 🎽
🤔 Additional Information
If you have any questions, just ask us directly in this issue by adding a comment. You can join our community chat at Discord. A general manual about open-source contributions can be found here.
The text was updated successfully, but these errors were encountered: