Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override default max gas refund property for some environments #408

Open
11 tasks
stoqnkpL opened this issue Oct 16, 2023 · 2 comments · May be fixed by #796
Open
11 tasks

Override default max gas refund property for some environments #408

stoqnkpL opened this issue Oct 16, 2023 · 2 comments · May be fixed by #796
Assignees
Labels
Good first issue Good for newcomers hacktoberfest Issues shown by lists for the Hacktoberfest and made for newcomers to do the first contribution.

Comments

@stoqnkpL
Copy link
Collaborator

stoqnkpL commented Oct 16, 2023

🆕🐥 First Timers Only

This issue is reserved for people who have never contributed to Hedera or any open source project in general.
We know that creating a pull request (PR) is a major barrier for new contributors.
The goal of this issue and all other issues labeled by 'Good First Issue' is to help you make your first contribution to Hedera.

👾 Description of the issue

Currently, when we process a transaction in the consensus node we populate a field in the transaction receipt, called gasUsed which is the larger number of the pair: 1. the actually consumed gas by the EVM and 2. gasLimit - 20% of gasLimit for the transaction.

The 20% of total gas limit max refund is configurable by an application property on the consensus node called contracts.maxRefundPercentOfGasLimit.

In order for devs to be able to see the actual gas used (regardless of the max refund logic), add custom manual configuration on local node by changing the global dynamic property maxGasRefundPercentage property from 20 to 100. This would eliminate the refund policy in the consensus node and the gasUsed field would take the actually gas consumed value.

Proposed Solution:

Add the contracts.maxRefundPercentOfGasLimit property in compose-network/network-node/application.properties and set its value to 100.

📋 Step by step guide to do a contribution

If you have never contributed to an open source project at GitHub, the following step-by-step guide will introduce you to the workflow. More information and concrete samples for shell commands for each step can be found in our CONTRIBUTING.md file.
A more detailed general documentation of the GitHub PR workflow can be found here.

  • Claim this issue: Comment below that you are interested in working on the issue
  • Wait for assignment: A community member with the given rights will add you as an assignee of the issue
  • Fork the repository: You can do that in GitHub (by simply clicking the 'fork' button).
  • Check out the forked repository
  • Create a feature branch for the issue. We do not have a hard naming definition for branches but it is best practice to prefix the branch name with the issue id.
  • Solve the issue in your branch.
  • Commit your changes: Here, it is needed to add sign-off information to the commit to accept the "Developer Certificate of Origin" (https://developercertificate.org). More details can be found in our CONTRIBUTING.md
  • Start a Pull Request (PR): We have a pattern for naming pull requests that a GitHub Action checks. We use that pattern to support the creation of automatic release notes.
  • Check GitHub Actions: Several GitHub Actions will be triggered automatically for each PR. If a GitHub Action fails and you do not understand the cause of that error do not hesitate to add a comment to the PR and ask the Hedera developer community for support.
  • Wait for reviews: Members of the Hedera developer community will review your PR. If a reviewer finds any missing pieces or a problem, he or she will start a discussion with you and describe the next steps for solving the problem.
  • You did it 🎉: We will merge the fix in the develop branch. Thanks for being part of the Hedera community as an open-source contributor ❤️

🎉 Contribute to Hacktoberfest

Solve this issue as part of the Hacktoberfest event and get a chance to receive cool goodies like a T-Shirt. 🎽

🤔 Additional Information

If you have any questions, just ask us directly in this issue by adding a comment. You can join our community chat at Discord. A general manual about open-source contributions can be found here.

@Nana-EC Nana-EC added the good first issue candidate Issues that can become a good first issue but need more description/context. label Sep 16, 2024
@Ivo-Yankov Ivo-Yankov added Good first issue Good for newcomers hacktoberfest Issues shown by lists for the Hacktoberfest and made for newcomers to do the first contribution. and removed good first issue candidate Issues that can become a good first issue but need more description/context. Limechain labels Oct 14, 2024
@Toprun123
Copy link

Toprun123 commented Oct 15, 2024

Can I try this. Please assign it to me. I have never done a code contribution before.

Edit: I just did my first code-based PR in another unrelated repo (Not merged).

@Toprun123
Copy link

I have opened a PR for this: #796 . Hope it works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good first issue Good for newcomers hacktoberfest Issues shown by lists for the Hacktoberfest and made for newcomers to do the first contribution.
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

4 participants