Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Flask-Lastuser integration into Baseframe as an optional module #68

Open
jace opened this issue Dec 30, 2014 · 0 comments
Open

Move Flask-Lastuser integration into Baseframe as an optional module #68

jace opened this issue Dec 30, 2014 · 0 comments

Comments

@jace
Copy link
Member

jace commented Dec 30, 2014

HasGeek apps currently depend on Flask-Lastuser, but in the hgapp structure of all apps, Baseframe (which handles UI) and Flask-Lastuser (which handles auth) have no explicit awareness of each other. Baseframe however does refer to the g.user object which is expected to be a Lastuser User object.

All code related to Flask-Lastuser integration in the app is in the hgapp skeleton, which makes it difficult to make upgrades as patches have to be applied manually to all hgapp-based apps. Baseframe has started adding functionality to apps since it acquired an init_app method -- most recently cache and assets and some awareness of the Lastuser extension -- but still no explicit handling for Flask-Lastuser.

This should change. Flask-Lastuser should be provided by Baseframe, including the boilerplate methods in login.py.

@jace jace mentioned this issue Nov 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant