fix: wrong line profile information #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoamGaash
approved these changes
Mar 12, 2024
|
@all-contributors please add @davis0011 for code and @aviv1620 for review 👏 |
|
I've put up a pull request to add @davis0011! 🎉 |
|
@all-contributors |
|
@davis0011 already contributed before to code I've put up a pull request to add @aviv1620! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When pressing on line number to see line profile, it shows the right line information
It used to take line number as id, and now takes the real id for the correct line
This pull request comes to solve issue #565
screenshots
before the change(wrong line information):
It gave the wrong information after pressing 25(for the line profile):
And after the change: