feat: improve design of about page #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shootermv
force-pushed
the
improve-design-of-about-page
branch
from
d2436ed to
562334d
Compare
|
it looks so much better! 👏 👏 👏 |
NoamGaash
approved these changes
Dec 12, 2023
src/pages/about/About.scss
Outdated
| } | ||
|
|
||
| li img { | ||
| width: 5%; |
There was a problem hiding this comment.
did you check that on different screen sizes?
There was a problem hiding this comment.
is there something wrong you can see now?
There was a problem hiding this comment.
changed img width to 1.9em
There was a problem hiding this comment.
I didn't check how it looks, only the code and screenshot.
consider adding margin-right and bullets to list
shootermv
force-pushed
the
improve-design-of-about-page
branch
from
562334d to
6a6e2b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add some improvements to about page styling
closes #288
screenshots