Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types(VoiceRegion): deprecated vip property #254

Merged
merged 1 commit into from
Oct 5, 2021
Merged

types(VoiceRegion): deprecated vip property #254

merged 1 commit into from
Oct 5, 2021

Conversation

almeidx
Copy link
Contributor

@almeidx almeidx commented Oct 5, 2021

About

Follow up to #253

Upstream pull request:

Status

  • These changes have been tested against Discord API or do not contain API change.
  • This PR includes only documentation changes, no code change.
  • This PR introduces some Breaking changes.

@almeidx almeidx changed the title refactor(VoiceRegion): removed vip property types(VoiceRegion): deprecated vip property Oct 5, 2021
@almeidx almeidx mentioned this pull request Oct 5, 2021
Closed
3 tasks
DjDeveloperr
DjDeveloperr approved these changes Oct 5, 2021
View reviewed changes
Copy link
Member

@DjDeveloperr DjDeveloperr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@DjDeveloperr DjDeveloperr merged commit 1a37f1e into harmonyland:main Oct 5, 2021
@almeidx almeidx deleted the vip-region branch October 5, 2021 11:47
invalidCards pushed a commit to invalidCards/harmony that referenced this pull request Nov 3, 2021
@almeidx @invalidCards
types(VoiceRegion): deprecated vip property (harmonyland#254)
0f15d86
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DjDeveloperr DjDeveloperr DjDeveloperr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@almeidx @DjDeveloperr