-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
View change: Support for checking if validators belongs to the same key. #4802
Open
Frozen
wants to merge
14
commits into
dev
Choose a base branch
from
feature/view-change-switch-validator-by-address
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophoah
reviewed
Nov 21, 2024
sophoah
reviewed
Nov 21, 2024
sophoah
reviewed
Nov 21, 2024
sophoah
reviewed
Nov 21, 2024
sophoah
reviewed
Nov 22, 2024
@Frozen can you help rebase and fix conflict here. |
Frozen
force-pushed
the
feature/view-change-switch-validator-by-address
branch
from
November 27, 2024 22:04
ba7d2a5
to
37e81e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for checking if validators belongs to the same key.
Leader Rotation based on
getLeaderPubKey
which is different for each iteration, while the view change it stays the same all time, that's why it requires additional actions for leader selection.Based on feature
IsLeaderRotationV2Epoch
applies methodgetNextLeaderKeySkipSameAddress
.