Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rust 1.80 dependency breakage #145

Merged
merged 1 commit into from
Aug 10, 2024

Conversation

cafkafk
Copy link
Contributor

@cafkafk cafkafk commented Aug 10, 2024

Rust 1.80.0 unfortunately had a breaking change, affecting the time
crate. This PR updates the time crate, as well as
[email protected] -> [email protected], since that had also
broken in the meantime.

Refs: NixOS/nixpkgs#332957
Signed-off-by: Christina Sørensen [email protected]

Rust 1.80.0 unfortunately had a breaking change, affecting the `time`
crate. This PR updates the time crate, as well as
`[email protected]` -> `[email protected]`, since that had also
broken in the meantime.

Refs: NixOS/nixpkgs#332957
Signed-off-by: Christina Sørensen <[email protected]>
@cafkafk
Copy link
Contributor Author

cafkafk commented Aug 10, 2024

I would also recommend releasing a new version after merging this, to ensure distributions that package xiu (like NixOS) can stay on a stable version.

@harlanc
Copy link
Owner

harlanc commented Aug 10, 2024

Thank you for the very timely PR. I just happened to encounter an issue with the workflow compilation failure caused by the time crate.

@harlanc harlanc merged commit eed8bdb into harlanc:master Aug 10, 2024
1 check passed
@cafkafk cafkafk deleted the fix-1.80.0-breakage branch August 10, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants