Is the RTMP chunk type not fully supported?

[udoless]

I was looking at the code of the zip_chunk_header method, and it seems like the 'if' logic inside should never be executed (because self.csid_2_chunk_header is always empty and there is no assignment to it).

xiu/protocol/rtmp/src/chunk/packetizer.rs

Lines 37 to 63 in 3a2faab

	fn zip_chunk_header(&mut self, chunk_info: &mut ChunkInfo) -> Result<PackResult, PackError> {
	chunk_info.basic_header.format = 0;
	let pre_header = self
	.csid_2_chunk_header
	.get_mut(&chunk_info.basic_header.chunk_stream_id);
	if let Some(val) = pre_header {
	let cur_msg_header = &mut chunk_info.message_header;
	let pre_msg_header = &val.message_header;
	if cur_msg_header.msg_streamd_id == pre_msg_header.msg_streamd_id {
	chunk_info.basic_header.format = 1;
	cur_msg_header.timestamp -= pre_msg_header.timestamp;
	if cur_msg_header.msg_type_id == pre_msg_header.msg_type_id
	&& cur_msg_header.msg_length == pre_msg_header.msg_length
	{
	chunk_info.basic_header.format = 2;
	if chunk_info.message_header.timestamp == pre_msg_header.timestamp {
	chunk_info.basic_header.format = 3;
	}
	}
	}
	}
	Ok(PackResult::Success)
	}

[harlanc]

Thanks for your report, you are right, some logics are missed and the Chunk header should be cached in the csid_2_chunk_header , could you do some fix and make a PR?

[udoless]

Thank you for the response. I'm not very familiar with this project right now, but I can give it a try if there's an opportunity in the future.

[harlanc]

I added the missing logic and did some simple tests, now different format types can be set for RTMP chunks, any other questions please let me know.