Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title Bars not properly hidden on Wayland in winit apps #358

Closed
Redoxahmii opened this issue Dec 4, 2023 · 3 comments
Closed

Title Bars not properly hidden on Wayland in winit apps #358

Redoxahmii opened this issue Dec 4, 2023 · 3 comments

Comments

@Redoxahmii
Copy link

Redoxahmii commented Dec 4, 2023

Describe the bug
The titlebar is not being hidden on Wayland for some applications

To Reproduce

  1. Install Neovide
  2. Open it and see that the windows top bar does not disappear.
  3. Works fine on Xorg.

Expected behavior
display no titlebar

Screenshots

On Wayland

Screenshot from 2023-12-05 01-57-44
On Xorg

Screenshot from 2023-12-05 02-07-29

Environment (please complete the following information):

  • OS: Arch Linux
  • GNOME Shell Version: 45.2
  • Unite version : 77

Logs
Dec 04 17:08:17 Ahmii gnome-shell[686]: Extension [email protected] already installed in /usr/share/gnome-shell/extensions/[email protected]. /usr/share/gnome-shell/extensions/[email protected] will not be loaded Dec 05 01:27:26 Ahmii gnome-shell[1437]: Can't update stage views actor <unnamed>[<Gjs_unite_hardpixel_eu_buttons_UniteTrayIndicator>:0x5578b049cc00] is on because it needs an allocation. Dec 05 01:28:01 Ahmii gnome-shell[98032]: Extension [email protected] already installed in /usr/share/gnome-shell/extensions/[email protected]. /usr/share/gnome-shell/extensions/[email protected] will not be loaded

Additional context
Add any other context about the problem here.

@Redoxahmii Redoxahmii added the bug label Dec 4, 2023
@jonian
Copy link
Member

jonian commented Dec 6, 2023

Hi @Redoxahmii, thanks for the report. On wayland only GTK apps are supported (using css), apps that use libdecor and Xwayland apps.

Neovide uses winit which does not use standard decorations, neither libdecor, but a custom implementation, as you can see at rust-windowing/winit#1967.

The only way to make the decorations removal work on wayland is to run neovide in xwayland mode:

WINIT_UNIX_BACKEND=x11 neovide

If you want you can add the env variable above in /etc/environment and any app that uses winit will run in xwayland mode without having to set the variable every time you run it.

@jonian jonian closed this as completed Dec 6, 2023
@jonian jonian removed the bug label Dec 6, 2023
@jonian jonian changed the title Title Bars not properly hidden on Wayland Title Bars not properly hidden on Wayland in winit apps Dec 6, 2023
@Redoxahmii
Copy link
Author

Thank you for responding. changing this has made it indeed work properly.
Thank you again.

@Redoxahmii
Copy link
Author

Hi @Redoxahmii, thanks for the report. On wayland only GTK apps are supported (using css), apps that use libdecor and Xwayland apps.

Neovide uses winit which does not use standard decorations, neither libdecor, but a custom implementation, as you can see at rust-windowing/winit#1967.

The only way to make the decorations removal work on wayland is to run neovide in xwayland mode:

WINIT_UNIX_BACKEND=x11 neovide

If you want you can add the env variable above in /etc/environment and any app that uses winit will run in xwayland mode without having to set the variable every time you run it.

Hey this method does not seem to be working anymore.
I reinstalled neovide and now it is again not working.
Is there someway to verify if it is being run X11 or not.

Below is the /etc/environment file

#
# This file is parsed by pam_env module
#
# Syntax: simple "KEY=VAL" pairs on separate lines
#
QT_QPA_PLATFORMTHEME=qt5ct
#QT_STYLE_OVERRIDE=kvantum
BROWSER=firefox
EDITOR=nvim
WINIT_UNIX_BACKEND=x11 neovide

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants