Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated the license to MIT #84

Merged
merged 2 commits into from
Aug 5, 2024
Merged

Conversation

Lakritzator
Copy link
Collaborator

@Lakritzator Lakritzator commented Sep 11, 2022

Also removed .NET 5.0 support as this is EOL.

Closes #56

@Lakritzator
Copy link
Collaborator Author

Created this for #56

@Lakritzator
Copy link
Collaborator Author

I also bumped up the version to 2.0.x as I consider a license change a potential breaking / major change.
Look at this to see how the file header was changed: https://github.com/hardcodet/wpf-notifyicon/pull/84/files#diff-ffd2fa4db00e15fe03e88dff6cc543d6be7000eeb99c57000dbfbdd44e90d889

@Lakritzator
Copy link
Collaborator Author

Lakritzator commented Sep 11, 2022

Oh, forgot, I also changed the namespace to use file scoped namespace. I probably regret that change, not for the change itself but as some PR will no longer merge without manual work. 🙄

I already regretted it, so I undid the change.

@trungnt2910
Copy link

trungnt2910 commented Sep 25, 2022

It's been a while, what's the status of this PR?
I also see that this branch has conflicts with the base.

@Lakritzator
Copy link
Collaborator Author

Life came in between, just wait.

@Lakritzator
Copy link
Collaborator Author

Hey @punker76 & @hardcodet can you take a look at this, so we can merge it?

@tstavropoulos
Copy link

Hey @Lakritzator and @hardcodet

I saw the discussion about this in #56. This is a really great project, and pulling in this license change would definitely make my life easier. Any chance of that happening? Thanks, and good luck!

LICENSE Outdated

Preamble
Copyright (c) Dapplo and Contributors
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to have been copy/pasted from Dapplo ;)

Copy link
Collaborator Author

@Lakritzator Lakritzator Jun 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn, I was hoping you would oversee it, so I have all rights... no just kidding.
Let me correct that...

@Linx-ESP
Copy link

Linx-ESP commented Jan 4, 2024

Any news?

@kjean667
Copy link

kjean667 commented Jun 11, 2024

I'm a bit interested in this license change as well due CPOL not being on a corporate's acceptable use list. Are there any stoppers from this being merged? @hardcodet @punker76

@punker76
Copy link
Collaborator

@Lakritzator @hardcodet LGTM

@punker76 punker76 added this to the 2.0.0 milestone Jun 11, 2024
@jeroenwalter
Copy link

jeroenwalter commented Jul 28, 2024

Hi, any chance that this PR can be added to the main base instead of waiting on a 2.0.0 milestone, that has no clear ETA?
I found this fork, https://github.com/HavenDV/H.NotifyIcon , that changed the license to MIT, but I don't think one can just change the license without the express permission of the current maintainers.

@punker76 punker76 merged commit e640cd8 into hardcodet:develop Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

License consideration?
8 participants