Improve icon selection to pick the best-fitting icon size from ICO files #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated ToIcon to select best-fitting icon from ICO file. - Added GetBestFitIcon to find the most appropriate icon size. - Modified SmallIconSize to use system metrics without DPI scaling. - Remove unnecessary ScaleWithDpi method. - Enhance icon selection for high-DPI clarity. - Add error handling for invalid ICO files. - Ensure proper resource disposal with using statements.
|
your changes have been merged, thanks for your contribution 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After updating to version 2.0.0, the
ScaleWithDpimethod forSizeconsistently sets the tray icon to 16x16 pixels, ignoring system DPI and application DPI awareness. This leads to poorly scaled icons on high-DPI displays.To fix this, I added the
GetBestFitIconmethod, which parses the ICO file and selects the most suitable icon based on the current DPI andSmallIconSize. I also removed unnecessary caching inSmallIconSizeand simplified it.Examples:
This change addresses incorrect scaling logic and improves icon appearance in the system tray across different DPI settings.
Likely resolves issue #75
Closes #75