Jettison generic pool from outbound #3115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @msimerson , I will test this out later today/tomorrow. |
related to #3113, which removed it from smtp_* plugins
msimerson
force-pushed
the
jettison-generic-pool
branch
from
6c9ecec
to
a2f1228
Compare
|
Sorry, first the internet was down and then I got the flu last few weeks. @msimerson I tested this now and all our CI tests pass. I will report any issues as I find them. Thanks! |
|
No issues so far. |
|
Same here. I was able to do additional testing and deployments before the holiday week and all is looking good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #3100
Fixes #2717
Checklist:
Background
The use of generic-pool has long been problematic. After a long period of being stuck on v2, I recently updated to v3, which has a new promises API. That update then started causing problems for some users because generic-pool started emitting new timeout errors, which weren't mentioned in the updating docs. Hours of tracing and debugging. I also discovered that a function we used was also removed entirely and again, no mention in the docs, so I also fixed that. So now our pooling code is back to working as well as it ever has, which is to say, it mostly works, but it still has a number of edge cases, a few of which are documented in #2717, #2945, #3022, and #3100.
Part of me thinks, "disable pooling code by default and document it with a THAR BE DRAGONS." The rest of me thinks, it's code that introduces a lot of complexity while chasing after a little bit of performance, get rid of it.