Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update deprecated calls to Buffer() #2553

Merged
merged 1 commit into from
Dec 7, 2018

Conversation

msimerson
Copy link
Member

Fixes #2374

Changes proposed in this pull request:

Checklist:

  • docs updated
  • tests updated
  • Changes updated

@msimerson msimerson changed the title update deprecated calls to Buffer()` -m fixes update deprecated calls to Buffer() Dec 6, 2018
@codecov
Copy link

codecov bot commented Dec 6, 2018

Codecov Report

Merging #2553 into master will decrease coverage by 0.02%.
The diff coverage is 56.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2553      +/-   ##
==========================================
- Coverage   59.45%   59.42%   -0.03%     
==========================================
  Files          28       28              
  Lines        6200     6199       -1     
  Branches     1543     1542       -1     
==========================================
- Hits         3686     3684       -2     
- Misses       2514     2515       +1
Impacted Files Coverage Δ
server.js 38.66% <0%> (-0.21%) ⬇️
transaction.js 88.52% <100%> (ø) ⬆️
messagestream.js 71.95% <25%> (ø) ⬆️
chunkemitter.js 59.57% <33.33%> (ø) ⬆️
mailheader.js 86.45% <50%> (ø) ⬆️
dkim.js 75.15% <66.66%> (ø) ⬆️
mailbody.js 83.46% <70%> (ø) ⬆️
connection.js 50.83% <75%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e36c17...8ec6c96. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 6, 2018

Codecov Report

Merging #2553 into master will decrease coverage by <.01%.
The diff coverage is 59.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2553      +/-   ##
==========================================
- Coverage   59.45%   59.44%   -0.01%     
==========================================
  Files          28       28              
  Lines        6200     6197       -3     
  Branches     1543     1542       -1     
==========================================
- Hits         3686     3684       -2     
+ Misses       2514     2513       -1
Impacted Files Coverage Δ
transaction.js 88.52% <100%> (ø) ⬆️
messagestream.js 71.95% <25%> (ø) ⬆️
chunkemitter.js 59.57% <33.33%> (ø) ⬆️
mailheader.js 86.45% <50%> (ø) ⬆️
connection.js 50.83% <66.66%> (-0.04%) ⬇️
dkim.js 75.15% <66.66%> (ø) ⬆️
mailbody.js 83.46% <70%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e36c17...004d1c2. Read the comment docs.

@msimerson msimerson force-pushed the 2374-buffer-updates branch 2 times, most recently from fa73fc0 to d14c6d1 Compare December 6, 2018 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant