Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dnsbl.zones, so overrides are better #1373

Merged
merged 1 commit into from
Mar 6, 2016
Merged

remove dnsbl.zones, so overrides are better #1373

merged 1 commit into from
Mar 6, 2016

Conversation

msimerson
Copy link
Member

We need to think about the optimal default configuration for this plugin.

As it stands, if someone configures the plugin like this:

echo 'zones=b.barracudacentral.org, truncate.gbudb.net' >> config/dnsbl.ini

They'll also have zen.spamhaus.org configured as well, because it will be enabled in the invisible (to the user) config directory. This seems a POLA violation.

This PR isn't much better, in that if someone were to do this:

echo 'b.barracudacentral.org' > config/dnsbl.zones

They'd once again be surprised to find that zen.spamhaus.org is active.

suggestion #1

Remove the docs for dnsbl.zones and encourage everyone to use dnsbl.ini.

suggestion #2

Now that we can have empty values in our .ini files, we could also deprecate both methods and replace them with an INI section:

[zones]
b.barracudacentral.org
truncate.gbudb.net
zen.spamhaus.org

@msimerson msimerson added this to the Install Easier milestone Mar 1, 2016
@smfreegard
Copy link
Collaborator

#1 gets my vote. Otherwise we break compatibility and I'd rather think about changing the config file when we introduce new functionality that might require it. e.g. you might want to look-up zen.spamhaus.org but only reject on 127.0.0.4 or .10 and .11 and raise some other flag for other hits etc. etc.

msimerson added a commit that referenced this pull request Mar 6, 2016
remove dnsbl.zones, so overrides are better
@msimerson msimerson merged commit e5daaca into haraka:master Mar 6, 2016
@msimerson msimerson deleted the dnsbl-config-default branch March 6, 2016 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants