remove dnsbl.zones, so overrides are better #1373
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to think about the optimal default configuration for this plugin.
As it stands, if someone configures the plugin like this:
They'll also have zen.spamhaus.org configured as well, because it will be enabled in the invisible (to the user) config directory. This seems a POLA violation.
This PR isn't much better, in that if someone were to do this:
They'd once again be surprised to find that zen.spamhaus.org is active.
suggestion #1
Remove the docs for dnsbl.zones and encourage everyone to use dnsbl.ini.
suggestion #2
Now that we can have empty values in our .ini files, we could also deprecate both methods and replace them with an INI section:
[zones] b.barracudacentral.org truncate.gbudb.net zen.spamhaus.org