Logs issued by connection.js don't use key-value pairs

[mfogel]

Summary

Some of the logs issued from connection.js don't make use of logging key-value pairs. Instead they stringify their data into their message. This makes them harder to parse them later on.

Steps To Reproduce

Use a default log.ini

[main]
level=info
timestamps=false
format=default

Then set up a client to drop a connection, which will trigger this call to loginfo: https://github.com/haraka/Haraka/blob/2.8.27/connection.js#L173

Expected behavior

The following gets logged:

[INFO] [C042AE7D-8968-4F9B-B7F2-4BA94D65F430] [core] client half closed connection ip=10.0.1.213

Actual behavior

The following gets logged:

[INFO] [C042AE7D-8968-4F9B-B7F2-4BA94D65F430] [core] client [10.0.1.213] half closed connection

System Info:

Haraka	Haraka.js — Version: 2.8.27
Node	v12.20.1
OS	Linux ip-10-0-1-69.ec2.internal 4.14.214-160.339.amzn2.aarch64 #1 SMP Sun Jan 10 05:53:19 UTC 2021 aarch64 aarch64 aarch64 GNU/Linux
openssl	OpenSSL 1.0.2k-fips 26 Jan 2017

[mfogel]

I can prepare a PR to implement this logging behavior change for these calls in connection.js if it's something the core dev team is open to. Cheers.

[msimerson]

Sounds like a log line was missed in #2047. A PR to update it/them is welcome.