Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hpal new outputs an unformatted package.json on ctrl-c'ing on npm init #42

Open
zemccartney opened this issue Apr 18, 2020 · 1 comment
Assignees
Labels

Comments

@zemccartney
Copy link
Member

Context

  • node version: 10, 12 (specifically, 10.20.0 and 12.16.2)
  • module version with issue: latest (2.4.0)

Steps to reproduce

  1. npx hpal new shreks-in-the-city
  2. Ctrl-C at start of npm init prompt, when the prompt reads "Press ^C at any time to quit".

Expected

  • project directory created
  • directory contains "unflavored" pal boilerplate contents
  • The "Bail on npm init" warning (maybe? wasn't sure about this)
  • package.json is properly formatted, name set to name of working directory (consistent with ctrl+c'ing out of npm init, when run directly) 

Actual

  • project directory created and boilerplate pulled down
  • No bail warning
  • Package.json isn't formatted, unspaced JSON
    • no "name" key set
@zemccartney
Copy link
Member Author

@devinivy i've done some tinkering with this while working through #38 and #39 , happy to take a crack at this one, too, if it feels worth it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant