Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support --no-color and --color flags #12

Open
devinivy opened this issue Apr 23, 2018 · 4 comments
Open

Support --no-color and --color flags #12

devinivy opened this issue Apr 23, 2018 · 4 comments

Comments

@devinivy
Copy link
Member

These flags are handled by the supports-color package—we just need to ensure they don't cause bossy to complain. Might need special handling for hpal run.

@wswoodruff
Copy link
Member

wswoodruff commented Oct 11, 2019

Tested this out locally, the setting is handled correctly by the supports-color package but bossy tracks those flags as arguments; should we explicitly strip those out of args?

@devinivy
Copy link
Member Author

We want those flags to decide whether hpal and hpal-debug provide colored output, and we want hpal run commands to do with those flags whatever they wish. So in short, they can't simply be stripped out of args if those same args are going to be passed along to an hpal run command. It's a slightly hairy problem to solve.

@jdonisvitch
Copy link
Member

Is the value of this feature worth the effort?

@wswoodruff
Copy link
Member

Got a proposal for this here #46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants