Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move route() and start() to the callback, check for error #37

Closed
wants to merge 1 commit into from
Closed

Move route() and start() to the callback, check for error #37

wants to merge 1 commit into from

Conversation

gergoerdosi
Copy link
Contributor

No description provided.

@hueniverse hueniverse added the documentation Non-code related changes label Aug 15, 2015
@kanongil
Copy link
Contributor

Thanks for the suggested fix, but there is no need to process the callback with the current versions of hapi & inert. Any registration error will be thrown immediately.

@gergoerdosi
Copy link
Contributor Author

Can you please point me to the relevant changes? Throwing immediately when a callback was not provided sounds good. Passing the error to the callback function sounds good as well. But then what's the point of requiring a callback, but not passing the error to it? Also, requiring a callback and suggesting users to just ignore it is the worst example we can show.

@kanongil
Copy link
Contributor

See hapijs/hapi#2690 for some background. I guess the sync attribute @hueniverse suggests in it could solve this in a more satisfactory manner?

@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Non-code related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants