Call captureStackTrace to filter boom from traces

[kpdecker]

Fixes #67

[arb]

Can you rewrite this as an if else? I find executing functions inside ternary operators a little hard to follow for the humans.

[kpdecker]

This is simply porting the existing code defined in the original method.

[arb]

Understood, but since you're in there anyway... 🍰

[kpdecker]

Will update later tonight.

[arb]

Do we want to expose something to make this behavior configurable?

[kpdecker]

Regarding making this configurable, what is the use case for consumers of boom (vs. authors of boom)? From the consumer perspective I can't think of a case where they should care about the internals. From the author perspective, you do loose some potential data but this seems to be a reasonable price considering the relatively limited internal complexity of the library and the benefit provided to users.

[hueniverse]

Dropping the boom part of the stack makes sense to me. I don't think a setting it useful here.

[kpdecker]

Changed the internal.internal method to internal.serverError

[arb]

This looks great. How do you think this should be versioned? My gut tells me major since we are changing the shape of the error stack and someone could be relying on the way it used to work.

Thoughts @hueniverse?

[kpdecker]

The error stack's content was never api, right? Major seems unnecessary.
Minor or patch would be a toss up in my mind but I could argue for either
one and feel like it's an ok choice.
On Tue, Sep 22, 2015 at 7:52 AM Adam Bretz [email protected] wrote:

This looks great. How do you think this should be versioned? My gut tells
me major since we are changing the shape of the error stack and someone
could be relying on the way it used to work.

Thoughts @hueniverse https://github.com/hueniverse?

—
Reply to this email directly or view it on GitHub
#68 (comment).

[AdriVanHoudt]

I would also go with minor or patch, not part of "public api" and would be weird to rely on the fact that it is in there imo

[hueniverse]

Minor.

[lock]

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.