Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpringBoot and Logback missing org/slf4j/impl/StaticLoggerBinder. Need to update to SpringBoot 3.0.1. #471

Closed
lukedegruchy opened this issue Jan 4, 2023 · 1 comment

Comments

@lukedegruchy
Copy link
Contributor

Please see: 466.

Background

  • In master, jpaserver-starter is using hapi-fhir 6.2.2, which uses an older version of Logback that still contains org/slf4j/impl/StaticLoggerBinder
  • In order to fix 466 (as of this writing, still pending), we needed to explicitly downgrade logback-core and logback-classic to 1.2.10. Otherwise, the application and unit tests will fail with java.lang.NoClassDefFoundError: org/slf4j/impl/StaticLoggerBinder
  • This issue is apparently fixed in Spring 3.0.1 and up: Upgrade to SLF4J 2.0 and Logback 1.4 spring-projects/spring-boot#12649

Fix

  • The ideal solution is to upgrade to SpringBoot 3.0.1 and explicitly within the jpaserver-starter pom.xml. This should not depend on any springboot configuration in hapi-fhir since that may be removed there entirely
  • However, this is a major version jump and will likely initially result in errors and dependencies to be resolved/upgraded
@jkiddo
Copy link
Collaborator

jkiddo commented Apr 16, 2024

@lukedegruchy we've upgraded now. Should this be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants