From 0c5e7b174ef8ac6351100ec6c555439f585f820c Mon Sep 17 00:00:00 2001
From: Hanno Braun <hanno@braun-odw.eu>
Date: Mon, 18 Mar 2024 12:13:30 +0100
Subject: [PATCH] Remove redundant validation check

This check essentially verified that the length of a half-edge is
non-zero, but I don't think this is actually important. At least I can't
think of a reason why it wouldn't work, and there might be legitimate
use cases.

What is important, is whether the vertices that bound the half-edge are
coincident, but in this regard, this check could have lead to false
positives, as the half-edge could be bounded by the same vertex on both
sides.

In addition, there are other validation checks that check for coincident
vertices, either existing in code, or tracked in issues.
---
 crates/fj-core/src/validate/edge.rs | 96 +----------------------------
 1 file changed, 3 insertions(+), 93 deletions(-)

diff --git a/crates/fj-core/src/validate/edge.rs b/crates/fj-core/src/validate/edge.rs
index 994be2fdf..d95b478ad 100644
--- a/crates/fj-core/src/validate/edge.rs
+++ b/crates/fj-core/src/validate/edge.rs
@@ -1,5 +1,3 @@
-use fj_math::{Point, Scalar};
-
 use crate::{
     geometry::Geometry,
     objects::HalfEdge,
@@ -11,101 +9,13 @@ use super::Validate;
 impl Validate for HalfEdge {
     fn validate(
         &self,
-        config: &ValidationConfig,
-        errors: &mut Vec<ValidationError>,
+        _: &ValidationConfig,
+        _: &mut Vec<ValidationError>,
         _: &Geometry,
     ) {
-        EdgeValidationError::check_vertex_coincidence(self, config, errors);
     }
 }
 
 /// [`HalfEdge`] validation failed
 #[derive(Clone, Debug, thiserror::Error)]
-pub enum EdgeValidationError {
-    /// [`HalfEdge`]'s vertices are coincident
-    #[error(
-        "Vertices of `Edge` on curve are coincident\n\
-        - Position of back vertex: {back_position:?}\n\
-        - Position of front vertex: {front_position:?}\n\
-        - `Edge`: {half_edge:#?}"
-    )]
-    VerticesAreCoincident {
-        /// The position of the back vertex
-        back_position: Point<1>,
-
-        /// The position of the front vertex
-        front_position: Point<1>,
-
-        /// The distance between the two vertices
-        distance: Scalar,
-
-        /// The edge
-        half_edge: HalfEdge,
-    },
-}
-
-impl EdgeValidationError {
-    fn check_vertex_coincidence(
-        edge: &HalfEdge,
-        config: &ValidationConfig,
-        errors: &mut Vec<ValidationError>,
-    ) {
-        let [back_position, front_position] = edge.boundary().inner;
-        let distance = (back_position - front_position).magnitude();
-
-        if distance < config.distinct_min_distance {
-            errors.push(
-                Self::VerticesAreCoincident {
-                    back_position,
-                    front_position,
-                    distance,
-                    half_edge: edge.clone(),
-                }
-                .into(),
-            );
-        }
-    }
-}
-
-#[cfg(test)]
-mod tests {
-    use fj_math::Point;
-
-    use crate::{
-        assert_contains_err,
-        objects::HalfEdge,
-        operations::build::BuildHalfEdge,
-        validate::{EdgeValidationError, Validate},
-        validation::ValidationError,
-        Core,
-    };
-
-    #[test]
-    fn edge_vertices_are_coincident() -> anyhow::Result<()> {
-        let mut core = Core::new();
-
-        let valid =
-            HalfEdge::line_segment([[0., 0.], [1., 0.]], None, &mut core);
-        let invalid = {
-            let boundary = [Point::from([0.]); 2];
-
-            HalfEdge::new(
-                valid.path(),
-                boundary,
-                valid.curve().clone(),
-                valid.start_vertex().clone(),
-            )
-        };
-
-        valid.validate_and_return_first_error(&core.layers.geometry)?;
-        assert_contains_err!(
-            core,
-            invalid,
-            ValidationError::Edge(
-                EdgeValidationError::VerticesAreCoincident { .. }
-            )
-        );
-
-        Ok(())
-    }
-}
+pub enum EdgeValidationError {}