export-validator doesn't support macOS and Windows
#920
Comments
hannobraun
added
help wanted
|
Thank you, @devanlooches! What platform is that? Looks like macOS with Intel hardware?
To support That directory has a README that says where the files come from. Basically, we need to add the right files from the SDK, maybe necessary symlinks to make sure the linker finds them, and then possibly adapt Any help doing that would be very appreciated! Labeling https://github.com/hannobraun/Fornjot/labels/help%20wanted, as I don't have access to the missing platforms. Also labeling https://github.com/hannobraun/Fornjot/labels/good%20first%20issue, as this is a build/linker issue that doesn't require any knowledge of Fornjot to figure out. |
hannobraun
changed the title
just build fails on export-validator stepexport-validator doesn't support macOS and Windows
|
Sorry for not giving more info. You are correct I'm on a macOS with Intel hardware. I tried putting the files in the libs/ directory but I'm still getting the same error message. |
For Linux, I had to make sure that the file has a very specific name, hence the symbolic link there. This required some experimentation though, and I'm a bit out of my depth there, especially regarding macOS. |
|
I just noticed @Michael-F-Bryan's lib3mf bindings. It seems it falls back to compiling lib3mf from source, if it can't find compiled binaries. Maybe using it could be the solution to this issue? |
|
My original intention behind creating that Unfortunately, I couldn't get Windows building reliably so I had to disable it in CI... Skimming through these build logs, I suspect it's an issue with their code and build system not being compatible with MSVC++. However, I hate debugging build systems for C/C++ projects so when I saw those errors and wasn't able to fix it easily, I threw the project in the too-hard basket and moved onto something else 😞 It works on MacOS, though! Edit: Actually, thinking on this a bit more... Maybe I should create an issue and post it to the Call For Participation section in This Week In Rust. |
|
Thanks for the info, @Michael-F-Bryan! Let's see how this shakes out. I also didn't want to mess around with any C/C++ builds, which is why I decided to just check the library files into Git. Not a bad approach actually, I think. |
|
from /Fornjot/tools/export-validator/lib3mf/README.md, just download lib3mf_sdk_v2.2.0.zip,unzip it, copy(overwrites needs maybe)lib files in /Bin to Fornjot/tools/export-validator/lib3mf/libs/, this issue resolved. |
|
Thank you for looking into this, @DengFX2010105421! I'd appreciate a pull request. I'd prefer not to do it myself, since I can't test it. |
|
I've come to the conclusion that it's a good idea to run the Export Validator for all platforms on the CI build, not just Linux. I tried to implement this today, using GitHub Actions as my test environment. It was a huge pain, but I managed to do so for macOS here: #1226 I absolutely failed to get it working for Windows, and I don't understand what the problem is. It just won't work. Here's my work-in-progress: #1230 Any help figuring this out would be highly appreciated! |
|
@hannobraun if you want, I'm more than happy to give you write access to my bindings repo. |
|
Thanks, @Michael-F-Bryan, but I'd rather not. I've spent way too much time trying to link yesterday, and I have no intention to spend more time trying to compile 😄 What I'll do is, I'll replace this issue with a more specific one that summarizes the current situation and what's wrong, and try to get some help dealing with it. I hope there will be enough interest from Windows users to take care of this. If not, I can live without |
|
Closing in favor of #1231. |
Error:
The text was updated successfully, but these errors were encountered: